Skip to content

Conversation

@yrodiere
Copy link
Member

DO NOT MERGE!

Not marking as draft because I need to run the whole CI, but still, do not merge.

This is only to check the impact of the upgrade -- which we are working on in hibernate/hibernate-orm#9478

See https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/Bytebuddy.201.2E15

@yrodiere yrodiere added the triage/on-ice Frozen until external concerns are resolved label Dec 20, 2024
@quarkus-bot

This comment was marked as off-topic.

@yrodiere yrodiere force-pushed the bytebuddy-1-15-11 branch 2 times, most recently from 94fb288 to 36fdb2b Compare December 20, 2024 15:25
@yrodiere yrodiere changed the base branch from main to 3.15 December 20, 2024 15:25
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding off until everything is in place

@geoand geoand changed the title [WIP] Upgrade to ByteBuddy 1.15.11 Upgrade to ByteBuddy 1.15.11 Dec 20, 2024
@yrodiere yrodiere removed the triage/on-ice Frozen until external concerns are resolved label Dec 20, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 20, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 71b5cb2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet changed the title Upgrade to ByteBuddy 1.15.11 [3.15] Upgrade to ByteBuddy 1.15.11 Dec 28, 2024
@yrodiere
Copy link
Member Author

yrodiere commented Jan 2, 2025

All checks passed, confirming the upgrade to this version of Bytebuddy would be fine, at least assuming Quarkus integration tests are representative.

Closing, will continue discussion (if necessary) on the Hibernate ORM PR: hibernate/hibernate-orm#9478

@yrodiere
Copy link
Member Author

yrodiere commented Jan 6, 2025

FYI the upgrade to ByteBuddy 1.15.11 was merged into Hibernate ORM's 6.6 branch. Tests passed. Unless we find last-minute problems with it, it will be part of Hibernate ORM 6.6.5, due to be released this Sunday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage/invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants