Skip to content

PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin #48040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin #48040

wants to merge 1 commit into from

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented May 24, 2025 •
edited
Loading

good idea to use Eclipse Formatter Profile as this seamless integrates with spotless.

Working with maven is very easy as the build fixes the code. This could be done here just the same. The config is already there.

[INFO] Index file corresponds to a different configuration of the plugin. Either the plugin version or its configuration has changed. Fallback to an empty index
[INFO] Spotless.Java is keeping 45 files clean - 1 needs changes to be clean, 44 were already clean, 0 were skipped because caching determined they were already clean
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  10.858 s
[INFO] Finished at: 2025-05-24T21:00:40+02:00
[INFO] ------------------------------------------------------------------------
[INFO] 1 goals, 1 executed
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.4:check (default-cli) on project quarkus-builder: The following files had format violations:
[ERROR]     src/main/java/io/quarkus/builder/diag/Diagnostic.java
[ERROR]         @@ -8,11 +8,11 @@
[ERROR]          import·io.quarkus.builder.location.Location;
[ERROR]          import·io.smallrye.common.constraint.Assert;
[ERROR]          
[ERROR]         -public·final·class··Diagnostic·{
[ERROR]         -····private·final·Level·level··;
[ERROR]         +public·final·class·Diagnostic·{
[ERROR]         +····private·final·Level·level;
[ERROR]          ····private·final·Location·location;
[ERROR]         -····private·final···················String·format;
[ERROR]         -private·final·Object[]·args;
[ERROR]         +····private·final·String·format;
[ERROR]         +····private·final·Object[]·args;
[ERROR]          ····private·final·Throwable·thrown;
[ERROR]          
[ERROR]          ····public·Diagnostic(final·Level·level,·final·Location·location,·final·String·format,·final·Object...·args)·{
[ERROR] Run 'mvn spotless:apply' to fix these violations.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

check:
Pasted Graphic

apply:
Pasted Graphic 1

unused:

image 
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.4:check (spotless-check) on project quarkus-smallrye-context-propagation: The following files had format violations:
[ERROR]     src/main/java/io/quarkus/smallrye/context/runtime/SmallRyeContextPropagationRecorder.java
[ERROR]         @@ -12,7 +12,6 @@
[ERROR]          
[ERROR]          import·org.eclipse.microprofile.context.ManagedExecutor;
[ERROR]          import·org.eclipse.microprofile.context.ThreadContext;
[ERROR]         -import·org.eclipse.microprofile.context.spi.ContextManager.Builder;
[ERROR]          import·org.eclipse.microprofile.context.spi.ContextManagerExtension;
[ERROR]          import·org.eclipse.microprofile.context.spi.ContextManagerProvider;
[ERROR]          import·org.eclipse.microprofile.context.spi.ThreadContextProvider;
[ERROR] Run 'mvn spotless:apply' to fix these violations.
[ERROR] -> [Help 1]

@Pankraz76
Copy link
Author

Pankraz76 commented May 24, 2025

wip

@Pankraz76 Pankraz76 closed this May 24, 2025
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right area/dependencies Pull requests that update a dependency file area/maven labels May 24, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented May 24, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@Pankraz76 Pankraz76 changed the title poc: integrate Eclipse Formatter Profile into Maven Spotless Plugin POC: integrate Eclipse Formatter Profile into Maven Spotless Plugin May 24, 2025
@Pankraz76 Pankraz76 mentioned this pull request May 24, 2025
Closed
@Pankraz76 Pankraz76 changed the title POC: integrate Eclipse Formatter Profile into Maven Spotless Plugin PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/dependencies Pull requests that update a dependency file area/maven triage/invalid This doesn't seem right

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Pankraz76