From 33ca1bb73d0b2ce8531668f7eb205f4ce06b58bd Mon Sep 17 00:00:00 2001 From: Holly Cummins Date: Mon, 17 Nov 2025 18:28:02 +0000 Subject: [PATCH] Do not do docker prune (that we don't do anyway), update readme Co-Authored-By: Guillaume Smet --- .../hibernate-reactive-oracle/pom.xml | 29 ------------------- integration-tests/jpa-oracle/README.md | 6 ++-- integration-tests/jpa-oracle/pom.xml | 29 ------------------- .../reactive-oracle-client/README.md | 8 ++--- .../reactive-oracle-client/pom.xml | 28 ------------------ 5 files changed, 7 insertions(+), 93 deletions(-) diff --git a/integration-tests/hibernate-reactive-oracle/pom.xml b/integration-tests/hibernate-reactive-oracle/pom.xml index cd5fc6e5bc03a..67e10d0d66740 100644 --- a/integration-tests/hibernate-reactive-oracle/pom.xml +++ b/integration-tests/hibernate-reactive-oracle/pom.xml @@ -166,35 +166,6 @@ - - docker-oracle - - - start-containers - - - - - - org.codehaus.mojo - exec-maven-plugin - - - docker-prune - generate-resources - - exec - - - ${docker-prune.location} - - - - - - - - podman diff --git a/integration-tests/jpa-oracle/README.md b/integration-tests/jpa-oracle/README.md index 7eb9852d8d8f4..18fcf93ea71ae 100644 --- a/integration-tests/jpa-oracle/README.md +++ b/integration-tests/jpa-oracle/README.md @@ -3,7 +3,7 @@ ## Running the tests -To run the tests in a standard JVM with an Oracle database started as a Docker container, you can run the following command: +To run the tests in a standard JVM with an Oracle database started as a Dev Service, you can run the following command: ``` mvn verify -Dtest-containers -Dstart-containers @@ -17,7 +17,7 @@ mvn verify -Dtest-containers -Dstart-containers -Dnative Alternatively you can connect to your own Oracle database. Reconfigure the connection URL with `-Doracledb.url=jdbc:Oracle://...`; -Authentication parameters might need to be changed in the Quarkus configuration file `application.properties`. +Authentication parameters might need to be added in the Quarkus configuration file `application.properties`. ### Starting Oracle via docker @@ -25,5 +25,5 @@ Authentication parameters might need to be changed in the Quarkus configuration docker run --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-free:23-slim-faststart ``` -This will start a local instance with the configuration matching the parameters used by the integration tests of this module. +This will start a local instance. Update `application.properties` with the new configuration. diff --git a/integration-tests/jpa-oracle/pom.xml b/integration-tests/jpa-oracle/pom.xml index 56cefec52cc40..c191f75d451c3 100644 --- a/integration-tests/jpa-oracle/pom.xml +++ b/integration-tests/jpa-oracle/pom.xml @@ -174,35 +174,6 @@ - - - docker-oracle - - - start-containers - - - - - - org.codehaus.mojo - exec-maven-plugin - - - docker-prune - generate-resources - - exec - - - ${docker-prune.location} - - - - - - - diff --git a/integration-tests/reactive-oracle-client/README.md b/integration-tests/reactive-oracle-client/README.md index 4a2ebb5ea0dc2..31d8d04941c47 100644 --- a/integration-tests/reactive-oracle-client/README.md +++ b/integration-tests/reactive-oracle-client/README.md @@ -1,10 +1,10 @@ # Reactive Oracle example + ## Running the tests -By default, the tests of this module are disabled. -To run the tests in a standard JVM with an Oracle database started as a Docker container, you can run the following command: +To run the tests in a standard JVM with an Oracle database started as a Dev Service, you can run the following command: ``` mvn verify -Dtest-containers -Dstart-containers @@ -18,7 +18,7 @@ mvn verify -Dtest-containers -Dstart-containers -Dnative Alternatively you can connect to your own Oracle database. Reconfigure the connection URL with `-Dreactive-oracledb.url=jdbc:oracle:thin:...`; -Authentication parameters might need to be changed in the Quarkus configuration file `application.properties`. +Authentication parameters might need to be added in the Quarkus configuration file `application.properties`. ### Starting Oracle via docker @@ -26,4 +26,4 @@ Authentication parameters might need to be changed in the Quarkus configuration docker run --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-free:23-slim-faststart ``` -This will start a local instance with the configuration matching the parameters used by the integration tests of this module. +This will start a local instance. Update `application.properties` with the new configuration. diff --git a/integration-tests/reactive-oracle-client/pom.xml b/integration-tests/reactive-oracle-client/pom.xml index 2a939ad8e88c7..310f5a6345dc6 100644 --- a/integration-tests/reactive-oracle-client/pom.xml +++ b/integration-tests/reactive-oracle-client/pom.xml @@ -140,34 +140,6 @@ - - docker-oracle - - - start-containers - - - - - - org.codehaus.mojo - exec-maven-plugin - - - docker-prune - generate-resources - - exec - - - ${docker-prune.location} - - - - - - -