-
Notifications
You must be signed in to change notification settings - Fork 3k
Use dev services instead of external container for DB2 #51128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use dev services instead of external container for DB2 #51128
Conversation
|
/cc @gsmet (hibernate-orm) |
This comment has been minimized.
This comment has been minimized.
Named reactive datasources are not DB dependant, so they should work regardless, I wonder what path is triggering |
|
@holly-cummins I learned the hard way that something in DB2 (the "instance name"? not sure if it's the same thing as the DB name) is... wait for it... limited to 8 characters. Was that perhaps your problem? :) |
Gosh. In principle it shouldn't affect this, because these are existing tests that are just running on a dev service instead of an independent container. But along with all the optimisations I've been throwing out, there could have been some flag in the container configuration or container image that eased that restriction. I'll try a shorter name and report back! |
Shortening the datasource name doesn't make CI pass, but it does improve it. Five test failures without (https://github.com/holly-cummins/quarkus/actions/runs/19517834498), two failures with (https://github.com/holly-cummins/quarkus/actions/runs/19577145253). The health check test reckons the database is up now, which is encouraging. The error now is So the error is still on the named datasource, but it's got further. What's also interesting is that the external DB2 doesn't seem to suffer from the name-length restriction, so there may be something we can do to make the dev service work, but I'll raise a separate issue for that once we get to the bottom of it. |
Partial resolution of #44124.
This is failing at the moment, because of the following error:
Looking at the difference between the passing code and the failing code, it seems like the named reactive datasources don't work with DB2? I can't debug locally because DB2 also doesn't start on my mac (#51084). I have no idea if this is a test problem or an application problem. I assume a test problem, but the modified test looks pretty innocuous. Any ideas, @lucamolteni or @yrodiere?