|
1 | 1 | --- |
2 | 2 | working-groups: |
| 3 | + - title: "Test classloading" |
| 4 | + board-url: "https://github.com/orgs/quarkusio/projects/30" |
| 5 | + short-description: The goal of this working group is to rewrite Quarkus's test classloading, so that tests are run in the same classloader as the application under tests, and Quarkus extensions can do "Quarkus-y" manipulations of test classes. |
| 6 | + readme: | |
| 7 | + <p>At the moment, Quarkus tests are invoked using one classloader, and then executed in a different classloader. This mostly works well, but means some use cases don't work: extensions cannot manipulate test classes in the same way that they do normal application classes. For example, anything run via a JUnit @TestTemplate test case will see the un-transformed class.</p> |
| 8 | + <p>It also means we have extra user-facing complexity, such as the QuarkusTest*Callbacks](https://quarkus.io/guides/getting-started-testing#enrichment-via-quarkustestcallback):</p> |
| 9 | + <blockquote> |
| 10 | + <p>While it is possible to use JUnit Jupiter callback interfaces like BeforeEachCallback, you might run into classloading issues because Quarkus has to run tests in a custom classloader which JUnit is not aware of.</p> |
| 11 | + </blockquote> |
| 12 | + <p>A final benefit is a reduction in the internal complexity of our code. Hopping between classloaders during test execution takes a lot of work, and adds a lot of code! It also is brittle in places. For example, because the hop between classloaders relies on serialization in some cases, it's becoming harder to do as the JVM tightens up security restrictions. We used to rely on xstream, but that stopped working in Java 17. In https://github.com/quarkusio/quarkus/pull/40601, @dmlloyd moved us to use the JBoss Serializer, which works better, but might still be affected by future restrictions on class access.</p> |
| 13 | + <p>The goal of this working group is to allow test classes to fully participate in the 'quarkification' of classes. The mechanism for this is probably just to load the test classes with the classloader we intend to run them with, so that JUnit sees the 'correct' version of the class.</p> |
| 14 | + <ul> |
| 15 | + <li>Point of contact: @holly-cummins (@<strong>Holly Cummins</strong> on Zulip)</li> |
| 16 | + <li>Proposal: https://github.com/quarkusio/quarkus/discussions/41867</li> |
| 17 | + <li>Discussion: <a href="https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/">Zulip topic</a></li> |
| 18 | + </ul> |
| 19 | + status: on track |
| 20 | + completed: false |
| 21 | + last-activity: 2025-02-05 |
| 22 | + last-update-date: 2025-02-04 |
| 23 | + last-update: | |
| 24 | + We have the first clean CI! It resolves the following issues: |
| 25 | + |
| 26 | + - https://github.com/quarkusio/quarkus/issues/45349 |
| 27 | + - https://github.com/quarkusio/quarkus/issues/8446 |
| 28 | + - https://github.com/quarkusio/quarkus/issues/42000 |
| 29 | + - https://github.com/quarkusio/quarkus/issues/42006 |
| 30 | + - https://github.com/quarkusio/quarkus/issues/44320 |
| 31 | + |
| 32 | + There are ~360 TODOs in the code. The following problems are introduced by the changes: |
| 33 | + |
| 34 | + - Dev services start in the discovery phase ( |
| 35 | + https://github.com/quarkusio/quarkus/issues/45785 ) |
| 36 | + - Maven surefire.rerunFailingTestsCount option does not work in the case where there are test profiles or resources, unless the test order falls such that the failing test uses the last profile/resource ( |
| 37 | + https://github.com/quarkusio/quarkus/issues/46048) |
| 38 | + point-of-contact: "@holly-cummins (@<strong>Holly Cummins</strong> on Zulip)" |
| 39 | + proposal: https://github.com/quarkusio/quarkus/discussions/41867 |
| 40 | + discussion: https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/ |
3 | 41 | - title: "Observability.Next" |
4 | 42 | board-url: "https://github.com/orgs/quarkusio/projects/42" |
5 | 43 | short-description: Observability.Next is a strategic initiative to modernize the observability stack within the Quarkus framework, aiming to streamline and enhance its ability to monitor and manage distributed systems. |
@@ -84,44 +122,6 @@ working-groups: |
84 | 122 | last-update-date: 2024-12-17 |
85 | 123 | last-update: | |
86 | 124 | Starting tracking tasks fro the 3.19 LTS. |
87 | | - - title: "Test classloading" |
88 | | - board-url: "https://github.com/orgs/quarkusio/projects/30" |
89 | | - short-description: The goal of this working group is to rewrite Quarkus's test classloading, so that tests are run in the same classloader as the application under tests, and Quarkus extensions can do "Quarkus-y" manipulations of test classes. |
90 | | - readme: | |
91 | | - <p>At the moment, Quarkus tests are invoked using one classloader, and then executed in a different classloader. This mostly works well, but means some use cases don't work: extensions cannot manipulate test classes in the same way that they do normal application classes. For example, anything run via a JUnit @TestTemplate test case will see the un-transformed class.</p> |
92 | | - <p>It also means we have extra user-facing complexity, such as the QuarkusTest*Callbacks](https://quarkus.io/guides/getting-started-testing#enrichment-via-quarkustestcallback):</p> |
93 | | - <blockquote> |
94 | | - <p>While it is possible to use JUnit Jupiter callback interfaces like BeforeEachCallback, you might run into classloading issues because Quarkus has to run tests in a custom classloader which JUnit is not aware of.</p> |
95 | | - </blockquote> |
96 | | - <p>A final benefit is a reduction in the internal complexity of our code. Hopping between classloaders during test execution takes a lot of work, and adds a lot of code! It also is brittle in places. For example, because the hop between classloaders relies on serialization in some cases, it's becoming harder to do as the JVM tightens up security restrictions. We used to rely on xstream, but that stopped working in Java 17. In https://github.com/quarkusio/quarkus/pull/40601, @dmlloyd moved us to use the JBoss Serializer, which works better, but might still be affected by future restrictions on class access.</p> |
97 | | - <p>The goal of this working group is to allow test classes to fully participate in the 'quarkification' of classes. The mechanism for this is probably just to load the test classes with the classloader we intend to run them with, so that JUnit sees the 'correct' version of the class.</p> |
98 | | - <ul> |
99 | | - <li>Point of contact: @holly-cummins (@<strong>Holly Cummins</strong> on Zulip)</li> |
100 | | - <li>Proposal: https://github.com/quarkusio/quarkus/discussions/41867</li> |
101 | | - <li>Discussion: <a href="https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/">Zulip topic</a></li> |
102 | | - </ul> |
103 | | - status: on track |
104 | | - completed: false |
105 | | - last-activity: 2025-02-03 |
106 | | - last-update-date: 2025-02-04 |
107 | | - last-update: | |
108 | | - We have the first clean CI! It resolves the following issues: |
109 | | - |
110 | | - - https://github.com/quarkusio/quarkus/issues/45349 |
111 | | - - https://github.com/quarkusio/quarkus/issues/8446 |
112 | | - - https://github.com/quarkusio/quarkus/issues/42000 |
113 | | - - https://github.com/quarkusio/quarkus/issues/42006 |
114 | | - - https://github.com/quarkusio/quarkus/issues/44320 |
115 | | - |
116 | | - There are ~360 TODOs in the code. The following problems are introduced by the changes: |
117 | | - |
118 | | - - Dev services start in the discovery phase ( |
119 | | - https://github.com/quarkusio/quarkus/issues/45785 ) |
120 | | - - Maven surefire.rerunFailingTestsCount option does not work in the case where there are test profiles or resources, unless the test order falls such that the failing test uses the last profile/resource ( |
121 | | - https://github.com/quarkusio/quarkus/issues/46048) |
122 | | - point-of-contact: "@holly-cummins (@<strong>Holly Cummins</strong> on Zulip)" |
123 | | - proposal: https://github.com/quarkusio/quarkus/discussions/41867 |
124 | | - discussion: https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/ |
125 | 125 | - title: "WebSocket Next" |
126 | 126 | board-url: "https://github.com/orgs/quarkusio/projects/26" |
127 | 127 | short-description: WebSocket-Next related tasks |
|
0 commit comments