Skip to content

Commit 4276458

Browse files
committed
Sync working groups
1 parent 20633b2 commit 4276458

File tree

1 file changed

+27
-27
lines changed

1 file changed

+27
-27
lines changed

_data/wg.yaml

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,32 @@
11
---
22
working-groups:
3+
- title: "Test classloading"
4+
board-url: "https://github.com/orgs/quarkusio/projects/30"
5+
short-description: |
6+
The goal of this working group is to rewrite Quarkus's test classloading, so that tests are run in the same classloader as the application under tests, and Quarkus extensions can do "Quarkus-y" manipulations of test classes.
7+
readme: |
8+
<p>At the moment, Quarkus tests are invoked using one classloader, and then executed in a different classloader. This mostly works well, but means some use cases don't work: extensions cannot manipulate test classes in the same way that they do normal application classes. For example, anything run via a JUnit @TestTemplate test case will see the un-transformed class.</p>
9+
<p>It also means we have extra user-facing complexity, such as the QuarkusTest*Callbacks](https://quarkus.io/guides/getting-started-testing#enrichment-via-quarkustestcallback):</p>
10+
<blockquote>
11+
<p>While it is possible to use JUnit Jupiter callback interfaces like BeforeEachCallback, you might run into classloading issues because Quarkus has to run tests in a custom classloader which JUnit is not aware of.</p>
12+
</blockquote>
13+
<p>A final benefit is a reduction in the internal complexity of our code. Hopping between classloaders during test execution takes a lot of work, and adds a lot of code! It also is brittle in places. For example, because the hop between classloaders relies on serialization in some cases, it's becoming harder to do as the JVM tightens up security restrictions. We used to rely on xstream, but that stopped working in Java 17. In https://github.com/quarkusio/quarkus/pull/40601, @dmlloyd moved us to use the JBoss Serializer, which works better, but might still be affected by future restrictions on class access.</p>
14+
<p>The goal of this working group is to allow test classes to fully participate in the 'quarkification' of classes. The mechanism for this is probably just to load the test classes with the classloader we intend to run them with, so that JUnit sees the 'correct' version of the class.</p>
15+
<ul>
16+
<li>Point of contact: @holly-cummins (@<strong>Holly Cummins</strong> on Zulip)</li>
17+
<li>Proposal: https://github.com/quarkusio/quarkus/discussions/41867</li>
18+
<li>Discussion: <a href="https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/">Zulip topic</a></li>
19+
</ul>
20+
status: on track
21+
lts: false
22+
completed: false
23+
last-activity: 2025-04-09
24+
last-update-date: 2025-03-25
25+
last-update: |
26+
Major update: The PR which switched from 'load classes with the same classloader as JUnit classes' to 'load classes with the classloader which will be used to run them' has merged. This closes ~8 outstanding issues (while potentially creating some more caused by eager augmention).
27+
point-of-contact: "@holly-cummins (@<strong>Holly Cummins</strong> on Zulip)"
28+
proposal: https://github.com/quarkusio/quarkus/discussions/41867
29+
discussion: https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/
330
- title: "Quarkus 3.15 LTS"
431
board-url: "https://github.com/orgs/quarkusio/projects/28"
532
short-description: |
@@ -100,33 +127,6 @@ working-groups:
100127
deliverable: TBD
101128
point-of-contact: "@xstefank (@<strong>Martin Stefanko|448453</strong> on Zulip)"
102129
proposal: https://github.com/quarkusio/quarkus/discussions/46672
103-
- title: "Test classloading"
104-
board-url: "https://github.com/orgs/quarkusio/projects/30"
105-
short-description: |
106-
The goal of this working group is to rewrite Quarkus's test classloading, so that tests are run in the same classloader as the application under tests, and Quarkus extensions can do "Quarkus-y" manipulations of test classes.
107-
readme: |
108-
<p>At the moment, Quarkus tests are invoked using one classloader, and then executed in a different classloader. This mostly works well, but means some use cases don't work: extensions cannot manipulate test classes in the same way that they do normal application classes. For example, anything run via a JUnit @TestTemplate test case will see the un-transformed class.</p>
109-
<p>It also means we have extra user-facing complexity, such as the QuarkusTest*Callbacks](https://quarkus.io/guides/getting-started-testing#enrichment-via-quarkustestcallback):</p>
110-
<blockquote>
111-
<p>While it is possible to use JUnit Jupiter callback interfaces like BeforeEachCallback, you might run into classloading issues because Quarkus has to run tests in a custom classloader which JUnit is not aware of.</p>
112-
</blockquote>
113-
<p>A final benefit is a reduction in the internal complexity of our code. Hopping between classloaders during test execution takes a lot of work, and adds a lot of code! It also is brittle in places. For example, because the hop between classloaders relies on serialization in some cases, it's becoming harder to do as the JVM tightens up security restrictions. We used to rely on xstream, but that stopped working in Java 17. In https://github.com/quarkusio/quarkus/pull/40601, @dmlloyd moved us to use the JBoss Serializer, which works better, but might still be affected by future restrictions on class access.</p>
114-
<p>The goal of this working group is to allow test classes to fully participate in the 'quarkification' of classes. The mechanism for this is probably just to load the test classes with the classloader we intend to run them with, so that JUnit sees the 'correct' version of the class.</p>
115-
<ul>
116-
<li>Point of contact: @holly-cummins (@<strong>Holly Cummins</strong> on Zulip)</li>
117-
<li>Proposal: https://github.com/quarkusio/quarkus/discussions/41867</li>
118-
<li>Discussion: <a href="https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/">Zulip topic</a></li>
119-
</ul>
120-
status: on track
121-
lts: false
122-
completed: false
123-
last-activity: 2025-04-07
124-
last-update-date: 2025-03-25
125-
last-update: |
126-
Major update: The PR which switched from 'load classes with the same classloader as JUnit classes' to 'load classes with the classloader which will be used to run them' has merged. This closes ~8 outstanding issues (while potentially creating some more caused by eager augmention).
127-
point-of-contact: "@holly-cummins (@<strong>Holly Cummins</strong> on Zulip)"
128-
proposal: https://github.com/quarkusio/quarkus/discussions/41867
129-
discussion: https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/
130130
- title: "Roq :: Quarkus SSG"
131131
board-url: "https://github.com/orgs/quarkiverse/projects/6"
132132
short-description: |

0 commit comments

Comments
 (0)