Fix Windows installation error handling

When Scoop fails to download or install Quarto (e.g., 503 server errors),
the action would still report "Quarto Installed !" and succeed.

The PowerShell script had no error handling and the bash wrapper didn't
check exit codes, causing installation failures to be silently ignored.

Author: cderv

setup/action.yml

@@ -92,14 +92,28 @@ runs:
               else
                 powershell -File $GITHUB_ACTION_PATH/install-quarto-windows.ps1 ${{ inputs.version }}
               fi
+
+              # Check if installation succeeded
+              if [ $? -ne 0 ]; then
+                  echo "ERROR: Quarto installation failed"
+                  exit 1
+              fi
+
+              # Verify Quarto is available
+              if ! command -v quarto &> /dev/null; then
+                  echo "ERROR: Quarto installation completed but quarto command not found"
+                  exit 1
+              fi
+
+              echo "Quarto Installed !"
               ;;
             *)
               echo "$RUNNER_OS not supported"
               exit 1
               ;;
         esac
         [ ${{ runner.os }} != "Windows" ] && rm $installer
-        echo "Quarto Installed !"
+        [ ${{ runner.os }} != "Windows" ] && echo "Quarto Installed !"
       shell: bash
       working-directory: ${{ runner.temp }}
     - name: 'Install TinyTeX'

setup/install-quarto-windows.ps1

@@ -14,16 +14,54 @@
     ttps:/go.microsoft.com/fwlink/?LinkID=135170
 #>
 
-Invoke-WebRequest -useb get.scoop.sh -outfile 'install.ps1'
-.\install.ps1 -RunAsAdmin
-Join-Path (Resolve-Path ~).Path "scoop\shims" >> $Env:GITHUB_PATH
+# Exit immediately on errors
+$ErrorActionPreference = "Stop"
+
+try {
+    Invoke-WebRequest -useb get.scoop.sh -outfile 'install.ps1'
+    .\install.ps1 -RunAsAdmin
+    if ($LASTEXITCODE -ne 0) {
+        Write-Error "Scoop installation failed with exit code $LASTEXITCODE"
+        exit 1
+    }
+    Join-Path (Resolve-Path ~).Path "scoop\shims" >> $Env:GITHUB_PATH
+} catch {
+    Write-Error "Failed to download or install Scoop: $_"
+    exit 1
+}
 
 $version=$args[0]
 scoop bucket add r-bucket https://github.com/cderv/r-bucket.git
+if ($LASTEXITCODE -ne 0) {
+    Write-Error "Failed to add r-bucket with exit code $LASTEXITCODE"
+    exit 1
+}
+
 if ([string]::IsNullOrEmpty($version)) {
     scoop install quarto
+    if ($LASTEXITCODE -ne 0) {
+        Write-Error "Failed to install quarto with exit code $LASTEXITCODE"
+        exit 1
+    }
 } elseif ($version -eq 'pre-release') {
     Invoke-Expression -Command "scoop install quarto-prerelease"
+    if ($LASTEXITCODE -ne 0) {
+        Write-Error "Failed to install quarto-prerelease with exit code $LASTEXITCODE"
+        exit 1
+    }
 } else {
     Invoke-Expression -Command "scoop install quarto@$version"
+    if ($LASTEXITCODE -ne 0) {
+        Write-Error "Failed to install quarto version $version with exit code $LASTEXITCODE"
+        exit 1
+    }
 }
+
+# Verify Quarto is available
+$quartoPath = Get-Command quarto -ErrorAction SilentlyContinue
+if (-not $quartoPath) {
+    Write-Error "Quarto installation completed but quarto command not found in PATH"
+    exit 1
+}
+
+exit 0