Skip to content

Commit 003405c

Browse files
committed
chrome - change back to --headless as default.
And keep option to set it to old for QUARTO_CHROMIUM specified version
1 parent 3ec9918 commit 003405c

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

news/changelog-1.7.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,3 +66,4 @@ All changes included in 1.7:
6666
- ([#11441](https://github.com/quarto-dev/quarto-cli/issues/11441)): Don't add newlines around shortcodes during processing.
6767
- ([#11643](https://github.com/quarto-dev/quarto-cli/issues/11643)): Improve highlighting of nested code block inside markdown code block, i.e. using ` ```{{python}} ` or ` ```python ` inside ` ````markdown` fenced code block.
6868
- ([fb38eb5](https://github.com/quarto-dev/quarto-cli/commit/fb38eb56c11e09f44cef58fd3b697ff24bb5a3f3)) Use the `latest` parser for Acorn when analyzing JS code imported from OJS blocks.
69+
- ([#10532](https://github.com/quarto-dev/quarto-cli/issues/10532)): Quarto changed default of `--headless=old` to `--headless` as [Chrome 132 has removed old headless mode](https://developer.chrome.com/blog/removing-headless-old-from-chrome) and only support new mode. For using old mode, `QUARTO_CHROMIUM` could be set to a [new `chrome-headless-shell` binary](https://developer.chrome.com/blog/chrome-headless-shell) or too an older chrome version (between 128 and 132) and `QUARTO_CHROMIUM_HEADLESS_MODE` set to `old` for using old headless mode with that compatabitle version.

src/core/cri/cri.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export async function criClient(appPath?: string, port?: number) {
8585
const app: string = appPath || await getBrowserExecutablePath();
8686

8787
// Allow to adapt the headless mode depending on the Chrome version
88-
const headlessMode = getenv("QUARTO_CHROMIUM_HEADLESS_MODE", "old");
88+
const headlessMode = getenv("QUARTO_CHROMIUM_HEADLESS_MODE", "none");
8989

9090
const cmd = [
9191
app,
@@ -97,6 +97,9 @@ export async function criClient(appPath?: string, port?: number) {
9797
// move to the new mode. We'll use `--headless=old` as the default for now
9898
// until the new mode is more stable, or until we really pin a version as default to be used.
9999
// This is also impacting in chromote and pagedown R packages and we could keep syncing with them.
100+
// EDIT: 17/01/2025 - old mode is gone in Chrome 132. Let's default to new mode to unbreak things.
101+
// Best course of action is to pin a version of Chrome and use the chrome-headless-shell more adapted to our need.
102+
// ref: https://developer.chrome.com/blog/chrome-headless-shell
100103
`--headless${headlessMode == "none" ? "" : "=" + headlessMode}`,
101104
"--no-sandbox",
102105
"--disable-gpu",

0 commit comments

Comments
 (0)