Skip to content

Commit 045de68

Browse files
committed
revert noErrorsOrWarnings change
1 parent 46b9085 commit 045de68

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

tests/verify.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,12 @@ export const noErrorsOrWarnings: Verify = {
152152
verify: (outputs: ExecuteOutput[]) => {
153153
const isErrorOrWarning = (output: ExecuteOutput) => {
154154
return output.levelName.toLowerCase() === "warn" ||
155-
output.levelName.toLowerCase() === "error" ||
156-
output.msg.startsWith("(W)"); // this is a warning from quarto.log.warning()
155+
output.levelName.toLowerCase() === "error";
156+
// I'd like to do this but many many of our tests
157+
// would fail right now because we're assuming noErrorsOrWarnings
158+
// doesn't include warnings from the lua subsystem
159+
// ||
160+
// output.msg.startsWith("(W)"); // this is a warning from quarto.log.warning()
157161
};
158162

159163
const errorsOrWarnings = outputs.some(isErrorOrWarning);

0 commit comments

Comments
 (0)