Skip to content

Commit 1057712

Browse files
committed
cri - use --headless=old as default.
Chrome v128 changed the default from --headless=old to --headless=new in 2024-08. Old headless mode was effectively a separate browser render, and while more performant did not share the same browser implementation as headful Chrome. New headless mode will likely be useful to some, but in Quarto use cases like printing to PDF or screenshoting, we need more work to move to the new mode. We'll use `--headless=old` as the default for now until the new mode is more stable, or until we really pin a version as default to be used. This is also impacting in chromote and pagedown R packages and we could keep syncing with them.
1 parent eab8b4f commit 1057712

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/core/cri/cri.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,15 @@ export async function criClient(appPath?: string, port?: number) {
8080

8181
const cmd = [
8282
app,
83-
"--headless",
83+
// TODO: Chrome v128 changed the default from --headless=old to --headless=new
84+
// in 2024-08. Old headless mode was effectively a separate browser render,
85+
// and while more performant did not share the same browser implementation as
86+
// headful Chrome. New headless mode will likely be useful to some, but in Quarto use cases
87+
// like printing to PDF or screenshoting, we need more work to
88+
// move to the new mode. We'll use `--headless=old` as the default for now
89+
// until the new mode is more stable, or until we really pin a version as default to be used.
90+
// This is also impacting in chromote and pagedown R packages and we could keep syncing with them.
91+
"--headless=old",
8492
"--no-sandbox",
8593
"--disable-gpu",
8694
"--renderer-process-limit=1",

0 commit comments

Comments
 (0)