tests, smoke-all - add tests for error: true for IPython.display error

and tweak `ensureHtmlElementContents` to use named option in YAML

Author: cderv

tests/docs/smoke-all/jupyter/error/display-error-true-cell.qmd

@@ -0,0 +1,49 @@
+---
+title: test
+format: html
+_quarto:
+  tests:
+    html:
+      ensureHtmlElementContents: 
+        selectors: ['div.cell-output-error']
+        matches: ['ValueError\: Display phase error for HTML']
+        noMatches: []
+---
+
+With `error: true` in cell, this document should not error at rendering and Exception at IPython.display level should be shown in output. 
+
+By default `nbconvert` does not throw exception for error thrown by IPython display, on purpose as document output is still valid as there are other representation. 
+
+```{python}
+# First cell - create an object with a buggy _repr_html_ method
+class BuggyDisplay:
+    def __init__(self):
+        self.data = "This works fine"
+    
+    def _repr_html_(self):
+        # This error happens during display, not execution
+        raise ValueError("Display phase error for HTML!")
+
+    def _repr_markdown_(self):
+        # Markdown representation as fallback when HTML fails
+        return "**Markdown fallback:** " + self.data
+
+    def __repr__(self):
+        # This ensures the object has a string representation
+        return self.data
+
+# Create the object
+buggy = BuggyDisplay()
+```
+
+```{python}
+#| error: true
+# Second cell - display the object (triggers error in _repr_html_)
+# This will show an error in the output but won't stop execution
+buggy
+```
+
+```{python}
+# Third cell - proves execution continues
+print("Execution continued despite display error")
+```

tests/docs/smoke-all/jupyter/error/display-error-true-global.qmd

@@ -0,0 +1,49 @@
+---
+title: test
+format: html
+execute:
+  error: true
+_quarto:
+  tests:
+    html:
+      ensureHtmlElementContents: 
+        selectors: ['div.cell-output-error']
+        matches: ['ValueError\: Display phase error for Markdown']
+---
+
+With `error: true` this document should not error at rendering and Exception at IPython.display level should be shown in output. 
+
+By default `nbconvert` does not throw exception for error thrown by IPython display, on purpose as document output is still valid as there are other representation. 
+
+```{python}
+# First cell - create an object with a buggy _repr_html_ method
+class BuggyDisplay:
+    def __init__(self):
+        self.data = "This works fine"
+    
+    def _repr_html_(self):
+        # This error happens during display, not execution
+        return "<b>HTML fallback:</b> " + self.data
+
+    def _repr_markdown_(self):
+        # Markdown representation as fallback when HTML fails
+        raise ValueError("Display phase error for Markdown!")
+    
+    def __repr__(self):
+        # This ensures the object has a string representation
+        return self.data
+
+# Create the object
+buggy = BuggyDisplay()
+```
+
+```{python}
+# Second cell - display the object (triggers error in _repr_html_)
+# This will show an error in the output but won't stop execution
+buggy
+```
+
+```{python}
+# Third cell - proves execution continues
+print("Execution continued despite display error")
+```

tests/smoke/smoke-all.test.ts

@@ -211,7 +211,9 @@ function resolveTestSpecs(
                 throw new Error(`Using ensureLatexFileRegexMatches requires setting 'keep-tex: true' in file ${input}`);
               }
             }
-            if (typeof value === "object") {
+            
+            if (typeof value === "object" && Array.isArray(value)) {
+              // Only use spread operator for arrays
               verifyFns.push(verifyMap[key](outputFile.outputPath, ...value));
             } else {
               verifyFns.push(verifyMap[key](outputFile.outputPath, value));

tests/smoke/website/draft-utils.ts

@@ -26,11 +26,11 @@ export const hasContentLinksToDrafts = (siteDir: string) => {
 }
 
 export const hasEnvelopeLinksToDrafts = (siteDir: string) => {
-  return ensureHtmlElementContents(join(siteDir, "index.html"), ["#quarto-sidebar", "#quarto-header", ".quarto-listing-default"], ["Draft!!"], []);
+  return ensureHtmlElementContents(join(siteDir, "index.html"), { selectors: ["#quarto-sidebar", "#quarto-header", ".quarto-listing-default"], matches: ["Draft!!"], noMatches: [] });
 }
 
 export const doesntHaveEnvelopeLinksToDrafts = (siteDir: string) => {
-  return ensureHtmlElementContents(join(siteDir, "index.html"), ["#quarto-sidebar", "#quarto-header", ".quarto-listing-default"], [], ["Draft!!"]);
+  return ensureHtmlElementContents(join(siteDir, "index.html"), { selectors: ["#quarto-sidebar", "#quarto-header", ".quarto-listing-default"], matches: [], noMatches: ["Draft!!"] });
 }
 
 export const siteMapHasDraft = (siteDir: string) => {

tests/verify.ts

@@ -345,31 +345,33 @@ export const ensureHtmlElements = (
 };
 
 export const ensureHtmlElementContents = (
-  file: string,
-  selectors: string[],
-  matches: (string | RegExp)[],
-  noMatches: (string | RegExp)[]
+  file: string, 
+  options : {
+    selectors: string[],
+    matches: (string | RegExp)[],
+    noMatches?: (string | RegExp)[]
+  }
 ) => {
   return {
     name: "Inspecting HTML for Selector Contents",
     verify: async (_output: ExecuteOutput[]) => {
       const htmlInput = await Deno.readTextFile(file);
       const doc = new DOMParser().parseFromString(htmlInput, "text/html")!;
-      selectors.forEach((sel) => {
+      options.selectors.forEach((sel) => {
         const el = doc.querySelector(sel);
         if (el !== null) {
           const contents = el.innerText;
-          matches.forEach((regex) => {
+          options.matches.forEach((regex) => {
             assert(
               asRegexp(regex).test(contents),
-              `Required match ${String(regex)} is missing from selector ${sel}.`,
+              `Required match ${String(regex)} is missing from selector ${sel} content: ${contents}.`,
             );
           });
 
-          noMatches.forEach((regex) => {
+          options.noMatches?.forEach((regex) => {
             assert(
               !asRegexp(regex).test(contents),
-              `Unexpected match ${String(regex)} is present from selector ${sel}.`,
+              `Unexpected match ${String(regex)} is present from selector ${sel} content: ${contents}.`,
             );
           });