Merge pull request #9795 from quarto-dev/fix/ipynb/encoded-svg

Author: cderv

news/changelog-1.5.md

@@ -123,6 +123,7 @@ All changes included in 1.5:
 - ([#9635](https://github.com/quarto-dev/quarto-cli/issues/9635)): Respect `{shortcodes=false}` when resolving `include` shortcodes.
 - ([#9664](https://github.com/quarto-dev/quarto-cli/pull/9664)): Add `placeholder` shortcode to produce placeholder images.
 - ([#9665](https://github.com/quarto-dev/quarto-cli/issues/9665)): Fix issue with key-value arguments of shortcode handlers in code contexts.
+- ([#9793](https://github.com/quarto-dev/quarto-cli/issues/9793)): `embed` shortcode now correctly retrieve svg image from embdedded cell.
 
 ## Lightbox Images
 

src/core/jupyter/jupyter.ts

@@ -1930,9 +1930,15 @@ function mdImageOutput(
     ? (data as string[]).join("")
     : data as string;
 
-  // base64 decode if it's not svg
   const outputFile = join(options.assets.base_dir, imageFile);
-  if (mimeType !== kImageSvg) {
+  if (
+    // base64 decode if it's not svg
+    mimeType !== kImageSvg ||
+    // or if it is encoded svg; this could happen when used in embed context,
+    // as Pandoc will generate ipynb with base64 encoded svg data
+    // https://github.com/quarto-dev/quarto-cli/issues/9793
+    !/<svg/.test(imageText)
+  ) {
     const imageData = base64decode(imageText);
 
     // if we are in retina mode, then derive width and height from the image

tests/docs/smoke-all/2024/05/29/9713/main.qmd

@@ -0,0 +1,8 @@
+---
+format: typst
+_quarto:
+  tests:
+    typst: null
+---
+
+{{< embed plots.qmd#plot >}}

tests/docs/smoke-all/2024/05/29/9713/plots.qmd

@@ -0,0 +1,10 @@
+---
+title: "Plots"
+fig-format: svg
+---
+
+```{r}
+#| label: plot
+plot(1:10)
+```
+