improve replace extension tests, remove duplication

Author: Al Manning

src/publish/confluence/confluence-helper.ts

@@ -480,16 +480,15 @@ export const replaceExtension = (
   oldExtension: string,
   newExtension: string
 ) => {
-  const base = parse(fileName).name;
-  return `${base}${newExtension}`;
+  return fileName.replace(oldExtension, newExtension);
 };
 
 export const getTitle = (
   fileName: string,
   metadataByInput: Record<string, InputMetadata>
 ): string => {
   const qmdFileName = replaceExtension(fileName, ".xml", ".qmd");
-  console.log("qmdFileName", qmdFileName);
+
   const metadataTitle = metadataByInput[qmdFileName]?.title;
 
   const titleFromFilename = capitalizeWord(fileName.split(".")[0] ?? fileName);

tests/unit/confluence.test.ts

@@ -645,22 +645,22 @@ const runGetTitle = () => {
       author: "fake-author",
       date: "fake-date",
     },
-    "fake-file2.qmd": {
+    "folder/fake-file2.qmd": {
       title: "fake-title2",
       author: "fake-author2",
       date: "fake-date2",
     },
   };
 
-  otest(suiteLabel("valid"), async () => {
+  test(suiteLabel("valid"), async () => {
     const fileName = "fake-file.xml";
     const expected = "fake-title1";
     const result = getTitle(fileName, fakeInputMetadata);
     assertEquals(expected, result);
   });
 
   test(suiteLabel("valid2"), async () => {
-    const fileName = "fake-file2.xml";
+    const fileName = "folder/fake-file2.xml";
     const expected = "fake-title2";
     const result = getTitle(fileName, fakeInputMetadata);
     assertEquals(expected, result);
@@ -3772,7 +3772,6 @@ const runConvertForSecondPass = () => {
       server,
       parent
     );
-    console.log("result", result);
     assertEquals(expected, result);
   };