escape link contents

Author: Al Manning

src/publish/confluence/constants.ts

@@ -1,6 +1,6 @@
 export const DELETE_DISABLED = false;
 
-export const EXIT_ON_ERROR = true;
+export const EXIT_ON_ERROR = false;
 
 export const DESCENDANT_LIMIT = 500; // Render time would be the big worry here, we can consider paging in the future
 

src/resources/extensions/quarto/confluence/overrides.lua

@@ -115,7 +115,7 @@ function LinkConfluence(source, target, title, attr)
   end
 
     return "<a href='" .. escape(target,true) .. "' title='" ..
-            escape(title,true) .. "'>" .. source .. "</a>"
+            escape(title,true) .. "'>" .. escape(source, false) .. "</a>"
 end
 
 function CodeBlockConfluence(codeValue, languageValue)

src/resources/extensions/quarto/confluence/test-suite.lua

@@ -128,6 +128,19 @@ function TestLinkConfluence:testQMDAnchor()
 
   lu.assertEquals(actual, expected)
 end
+function TestLinkConfluence:testEscape()
+  local expected = "<a href='fake-target.qmd' title='fake-title'>A &amp; B</a>"
+  local source = 'A & B'
+  local target = 'fake-target.qmd'
+  local title = 'fake-title'
+  local attributes = {
+    class = 'fake-class'
+  }
+  expected = confluence.interpolate{expected, doubleBracket = ']]'}
+  local actual = confluence.LinkConfluence(source, target, title, attributes)
+
+  lu.assertEquals(actual, expected)
+end
 function TestLinkConfluence:testAttachment()
   local expected = [[<ac:link><ri:attachment ri:filename="fake-source"/><ac:plain-text-link-body><![CDATA[fake-target{doubleBracket}></ac:plain-text-link-body></ac:link>]]
   expected = confluence.interpolate{expected, doubleBracket = ']]'}