Render navbar href

Fixes #1627

Note that I allow shortcode looking hrefs through untouched now when resolving items. Otherwise they’ll resolve to `/{{< shortcode >}}`

Author: dragonstyle

src/project/types/website/website-navigation-md.ts

@@ -270,6 +270,10 @@ const navbarContentsHandler = (context: NavigationPipelineContext) => {
           if (entry.text) {
             markdown[`${kNavbarIdPrefix}${entry.text.trim()}`] = entry.text;
           }
+          if (entry.href) {
+            markdown[`${kNavbarIdPrefix}${entry.href.trim()}`] = entry.href;
+          }
+
           if (entry.menu?.entries) {
             for (const childEntry of entry.menu) {
               addEntry(childEntry);
@@ -301,6 +305,17 @@ const navbarContentsHandler = (context: NavigationPipelineContext) => {
               link.innerHTML = renderedEl?.innerHTML;
             }
           }
+
+          const textParent = link.parentElement;
+          if (textParent) {
+            const href = textParent.getAttribute("href");
+            if (href) {
+              const renderedHref = rendered[`${kNavbarIdPrefix}${href}`];
+              if (renderedHref) {
+                textParent.setAttribute("href", renderedHref?.innerText);
+              }
+            }
+          }
         }
       });
     },

src/project/types/website/website-navigation.ts

@@ -1408,6 +1408,8 @@ async function resolveItem<T extends { href?: string; text?: string }>(
         );
       }
       return inputItem;
+    } else if (looksLikeShortCode(href)) {
+      return item;
     } else {
       return {
         ...item,
@@ -1419,6 +1421,10 @@ async function resolveItem<T extends { href?: string; text?: string }>(
   }
 }
 
+function looksLikeShortCode(href: string) {
+  return href.startsWith("{{<") && href.endsWith(">}}");
+}
+
 function sidebarTitle(sidebar: Sidebar, project: ProjectContext) {
   const { navbar } = websiteNavigationConfig(project);
   if (sidebar.title) {