Skip to content

Commit 74c9641

Browse files
fixup! ask knitr to hold/coalesce echos when renderings is set
1 parent 36910e6 commit 74c9641

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

tests/docs/smoke-all/dark-mode/ggplot-brandless.qmd

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ ggplot(mtcars, aes(mpg, wt)) +
6363

6464
### with crossref but no caption
6565

66-
::: {#fig-ggplot}
66+
::: {#fig-thematic-ggplot}
6767
```{r}
6868
#| echo: true
6969
#| renderings:
@@ -89,13 +89,15 @@ ggplot(mtcars, aes(mpg, disp)) +
8989
geom_point(aes(colour = factor(cyl))) + colour_scale
9090
```
9191

92-
ggplot - dark only
92+
thematic - base r graphics
9393

9494
</div>
9595

96+
## patchwork
97+
9698
### with crossref and caption
9799

98-
::: {#fig-ggplot-mpg-hp}
100+
::: {#fig-thematic-patchwork}
99101
```{r}
100102
#| renderings: [light, dark]
101103
theme_set(united_theme)

tests/docs/smoke-all/dark-mode/ggplot-duobrand.qmd

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ ggplot(mtcars, aes(mpg, wt)) +
6565

6666
and `echo: true`
6767

68-
::: {#fig-ggplot}
68+
::: {#fig-thematic-ggplot}
6969

7070
```{r}
7171
#| echo: true
@@ -83,6 +83,8 @@ ggplot(mtcars, aes(mpg, disp)) +
8383

8484
### with caption but no crossref
8585

86+
dark rendering only
87+
8688
<div>
8789

8890
```{r}
@@ -91,14 +93,15 @@ ggplot(mtcars, aes(mpg, disp)) +
9193
geom_point(aes(colour = factor(cyl))) + slate_theme + colour_scale
9294
```
9395

94-
ggplot - dark only
96+
thematic - base r graphics
9597

9698
</div>
9799

100+
## patchwork
98101

99102
### with crossref and caption
100103

101-
::: {#fig-ggplot-mpg-hp}
104+
::: {#fig-thematic-patchwork}
102105
```{r}
103106
#| renderings: [light, dark]
104107
ggplot(mtcars, aes(mpg, hp)) +

0 commit comments

Comments
 (0)