Revert "brand processData: pass logo urls unchanged"

This reverts commit 47611e3.

Author: gordonwoodhull

news/changelog-1.8.md

@@ -23,7 +23,6 @@ All changes included in 1.8:
 - ([#10983](https://github.com/quarto-dev/quarto-cli/issues/10983)): Fix spacing inconsistency between paras and first section headings.
 - ([#12259](https://github.com/quarto-dev/quarto-cli/issues/12259)): Fix conflict between `html-math-method: katex` and crossref popups (author: @benkeks).
 - ([#12341](https://github.com/quarto-dev/quarto-cli/issues/12341)): Enable light and dark logos for html formats (sidebar, navbar, dashboard).
-- ([#12643](https://github.com/quarto-dev/quarto-cli/issues/12643)): Ensure brand.yml logos using urls are rendered correctly by passing them through when resolving brand `processedData`, and not processing them as paths.
 - ([#12734](https://github.com/quarto-dev/quarto-cli/issues/12734)): `highlight-style` now correctly supports setting a different `light` and `dark`.
 - ([#12747](https://github.com/quarto-dev/quarto-cli/issues/12747)): Ensure `th` elements are properly restored when Quarto's HTML table processing is happening.
 - ([#12766](https://github.com/quarto-dev/quarto-cli/issues/12766)): Use consistent equation numbering display for `html-math-method` and `html-math-method.method` for MathJax and KaTeX (author: @mcanouil)

src/core/brand/brand.ts

@@ -39,7 +39,6 @@ import {
   LogoSpecifier,
   LogoSpecifierPathOptional,
 } from "../../resources/types/schema-types.ts";
-import { isExternalPath } from "../../project/types/website/website-navigation.ts";
 
 type ProcessedBrandData = {
   color: Record<string, string>;
@@ -247,13 +246,11 @@ export class Brand {
   resolvePath(entry: BrandLogoResource) {
     const pathPrefix = relative(this.projectDir, this.brandDir);
     if (typeof entry === "string") {
-      return { path: isExternalPath(entry) ? entry : join(pathPrefix, entry) };
+      return { path: join(pathPrefix, entry) };
     }
     return {
       ...entry,
-      path: isExternalPath(entry.path)
-        ? entry.path
-        : join(pathPrefix, entry.path),
+      path: join(pathPrefix, entry.path),
     };
   }
 

src/project/types/website/website-navigation.ts

@@ -1567,7 +1567,7 @@ function navigationDependency(resource: string) {
   };
 }
 
-export function isExternalPath(path: string) {
+function isExternalPath(path: string) {
   return /^\w+:/.test(path);
 }