Setting error: false at cell level should have precedence

Author: cderv

src/resources/jupyter/notebook.py

@@ -517,7 +517,7 @@ def cell_execute(client, cell, index, execution_count, eval_default, store_histo
 
    # check options for eval and error
    eval = cell_options.get('eval', eval_default)
-   allow_errors = cell_options.get('error', False)
+   allow_errors = cell_options.get('error')
 
    trace(f"cell_execute with eval={eval}")
 
@@ -554,7 +554,7 @@ def cell_execute(client, cell, index, execution_count, eval_default, store_histo
             del cell["metadata"]["tags"]
 
       # Check for display errors in output (respecting both global and cell settings)
-      cell_allows_errors = client.allow_errors or allow_errors
+      cell_allows_errors = allow_errors if allow_errors is not None else client.allow_errors
       if not cell_allows_errors:
          for output in cell.outputs:
             if output.get('output_type') == 'error':

tests/docs/smoke-all/jupyter/error/display-error-true-global-cell-false.qmd

@@ -0,0 +1,47 @@
+---
+title: test
+format: html
+execute:
+  error: true
+_quarto:
+  tests:
+    html:
+      shouldError: default
+      postRenderCleanup:
+        - '${input_stem}.quarto_ipynb'
+---
+
+With `error: true`, and `error: false` at cell level, this document should error at rendering.
+
+By default `nbconvert` does not throw exception for error thrown by IPython display, on purpose as document output is still valid as there are other representation. 
+
+```{python}
+class BuggyDisplay:
+    def __init__(self):
+        self.data = "This works fine"
+    
+    def _repr_html_(self):
+        # HTML representation used for `format: html`
+        return "<b>HTML fallback:</b> " + self.data
+
+    def _repr_markdown_(self):
+        # This error happens during display, not execution
+        # even if the markdown reprensentation is not used
+        raise ValueError("Display phase error for Markdown!")
+    
+    def __repr__(self):
+        # This ensures the object has a string representation
+        return self.data
+
+# Create the object
+buggy = BuggyDisplay()
+```
+
+```{python}
+#| error: false
+buggy
+```
+
+```{python}
+print("Execution continued despite display error")
+```