chore: cleanup of deno lint/ vscode "problems", etc (#4608)

* add ignore directives to deno, clean up some lua diagnostics
* chore: deno lint
* lua-types cleanup
* fix minor schema bug
* build artifacts

Author: cscheid

.luarc.json

@@ -19,5 +19,6 @@
   "Lua.runtime.version": "Lua 5.3",
   "Lua.workspace.checkThirdParty": false,
   "Lua.workspace.library": ["src/resources/lua-types"],
+  "Lua.workspace.ignoreDir": ["tests/renv"],
   "Lua.runtime.plugin": "src/resources/lua-plugin/plugin.lua"
 }

deno.jsonc

@@ -0,0 +1,10 @@
+## tl;dr
+
+deno.jsonc currently doesn't support globs, so we have a script to expand the globs ourselves.
+
+## Steps
+
+```
+$ cd quarto-cli
+$ deno run --allow-all package/src/common/create-deno-config.ts > deno.jsonc
+```

dev-docs/update-deno_jsonc.md

@@ -82,9 +82,7 @@ import {
 } from "./freeze.ts";
 import { isJupyterNotebook } from "../../core/jupyter/jupyter.ts";
 import { MappedString } from "../../core/lib/text-types.ts";
-import {
-  waitUntilNamedLifetime,
-} from "../../core/lifetimes.ts";
+import { waitUntilNamedLifetime } from "../../core/lifetimes.ts";
 import { resolveDependencies } from "./pandoc-dependencies-html.ts";
 import {
   getData as getTimingData,
@@ -289,7 +287,7 @@ export async function renderFiles(
 
       if (progress) {
         renderProgress(
-          `[${String(i + 1).padStart(numWidth)}/${files.length}] ${
+          `\r[${String(i + 1).padStart(numWidth)}/${files.length}] ${
             relative(project!.dir, file.path)
           }`,
         );

src/command/render/render-files.ts

@@ -28,12 +28,7 @@ import {
   optionCommentPatternFromLanguage,
 } from "../lib/partition-cell-options.ts";
 import { ConcreteSchema } from "../lib/yaml-schema/types.ts";
-import {
-  pandocBlock,
-  pandocHtmlBlock,
-  pandocList,
-  pandocRawStr,
-} from "../pandoc/codegen.ts";
+import { pandocBlock, pandocList, pandocRawStr } from "../pandoc/codegen.ts";
 
 import {
   kCapLoc,
@@ -74,10 +69,6 @@ import { mappedStringFromFile } from "../mapped-text.ts";
 import { error } from "log/mod.ts";
 import { withCriClient } from "../cri/cri.ts";
 import { normalizePath } from "../path.ts";
-import {
-  extractHtmlFromElements,
-  extractImagesFromElements,
-} from "../puppeteer.ts";
 
 const handlers: Record<string, LanguageHandler> = {};
 

src/core/handlers/base.ts

@@ -367,11 +367,13 @@ mermaid.initialize(${JSON.stringify(mermaidOpts)});
     // deno-lint-ignore require-await
     const makeJs = async () => {
       setupMermaidJsRuntime();
-      const { baseName: tooltipName } = handlerContext
-        .uniqueFigureName(
-          "mermaid-tooltip-",
-          "",
-        );
+      // removed until we use mermaid 10.0.0
+      //
+      // const { baseName: tooltipName } = handlerContext
+      //   .uniqueFigureName(
+      //     "mermaid-tooltip-",
+      //     "",
+      //   );
       const preAttrs = [];
       if (options.label) {
         preAttrs.push(`label="${options.label}"`);

src/core/handlers/mermaid.ts

@@ -9,7 +9,6 @@ import { resourcePath } from "../resources.ts";
 import { getNamedLifetime, ObjectWithLifetime } from "../lifetimes.ts";
 
 import {
-  cleanEmptyJupyterAssets,
   jupyterAssets,
   jupyterFromFile,
   jupyterToMarkdown,
@@ -45,7 +44,7 @@ import {
 import { globalTempContext } from "../temp.ts";
 import { isAbsolute } from "path/mod.ts";
 import { partitionMarkdown } from "../pandoc/pandoc-partition.ts";
-import { normalizePath, removeIfEmptyDir, safeExistsSync } from "../path.ts";
+import { normalizePath, safeExistsSync } from "../path.ts";
 import { basename } from "path/mod.ts";
 
 export interface JupyterNotebookAddress {

src/core/jupyter/jupyter-embed.ts

@@ -466,7 +466,7 @@ export async function jupyterKernelspecFromMarkdown(
   markdown: string,
   project?: ProjectContext,
 ): Promise<[JupyterKernelspec, Metadata]> {
-  const config = (project as any)?.config;
+  const config = project?.config;
   const yaml = config
     ? mergeConfigs(config, readYamlFromMarkdown(markdown))
     : readYamlFromMarkdown(markdown);

src/core/jupyter/jupyter.ts

@@ -277,22 +277,6 @@ export function buildTreeSitterAnnotation(
     return dispatch[node.type](node);
   };
 
-  const annotateError = (
-    start: number,
-    end: number,
-    message: string,
-  ): AnnotatedParse => {
-    errors.push({ start, end, message });
-    return {
-      start,
-      end,
-      result: null,
-      kind: "<<ERROR>>",
-      components: [],
-      source: mappedSource,
-    };
-  };
-
   const annotateEmpty = (position: number): AnnotatedParse => {
     return {
       start: position,

src/core/lib/yaml-intelligence/annotated-yaml.ts

@@ -333,21 +333,16 @@ export function objectSchema(params: {
     // if we subclass from something with patternProperties that came from case convention
     // detection, ignore that.
 
-    let filtered = false;
     const propNamesArray = baseSchema.map((s) => s.propertyNames)
       .filter((s) => {
         if (typeof s !== "object") return true;
         if (s.tags === undefined) return true;
         if (s.tags["case-detection"] === true) {
-          filtered = true;
           return false;
         }
         return true;
       })
       .filter((s) => s !== undefined) as Schema[];
-    // if (propertyNames) {
-    //   propNamesArray.push(propertyNames);
-    // }
     if (propNamesArray.length === 1) {
       result.propertyNames = propNamesArray[0];
     } else if (propNamesArray.length > 1) {