Update ff-matrix workflow based on smoke test one

For now still a copy of the smoke test workflow, but we will refactor this to use the smoke test workflow as a base
and then add the additional steps needed for the feature format matrix tests.

Author: cderv

.github/workflows/test-ff-matrix.yml

@@ -2,6 +2,12 @@
 name: Feature-Format Tests
 on:
   workflow_dispatch:
+    inputs:
+      extra-r-packages:
+        description: "extra R package to install for the runs (like a dev version of one of the deps) - comma separated, passed to renv::install"
+        required: false
+        type: string
+        default: ""
   schedule:
     # run daily at 1am UTC
     - cron: "0 1 * * *"
@@ -73,14 +79,16 @@ jobs:
           cat("r-version=", R.Version()$version.string, "\n", file = Sys.getenv("GITHUB_OUTPUT"), sep = "", append = TRUE)
         shell: Rscript {0}
 
-      - name: Cache R packages
-        uses: actions/cache@v4
+      - name: Restore Renv package cache
+        id: cache-renv-packages-restore
+        uses: actions/cache/restore@v4
         with:
-          path: ${{ env.RENV_PATHS_ROOT }}
-          key: ${{ steps.get-version.outputs.os-version }}-${{ steps.get-version.outputs.r-version }}-renv-2-${{ hashFiles('tests/renv.lock') }}
+          path: |
+            ${{ env.RENV_PATHS_ROOT }}
+            renv/library
+          key: ${{ steps.get-version.outputs.os-version }}-${{ steps.get-version.outputs.r-version }}-renv-3-${{ hashFiles('tests/renv.lock') }}
           restore-keys: |
-            ${{ steps.get-version.outputs.os-version }}-${{ steps.get-version.outputs.r-version }}-renv-2-
-          save-always: true
+            ${{ steps.get-version.outputs.os-version }}-${{ steps.get-version.outputs.r-version }}-renv-3-
 
       - name: Install missing system deps
         if: runner.os == 'Linux'
@@ -89,6 +97,7 @@ jobs:
           sudo apt-get install -y libcurl4-openssl-dev
           sudo apt-get install -y libxml2-utils
           sudo apt-get install -y libharfbuzz-dev libfribidi-dev
+          sudo apt-get install -y poppler-utils
 
       - name: Restore R packages
         working-directory: tests
@@ -97,12 +106,26 @@ jobs:
           renv::restore()
           # Install dev versions for our testing
           # Use r-universe to avoid github api calls
-          try(install.packages('knitr', repos = 'https://yihui.r-universe.dev'))
-          try(install.packages('rmarkdown', repos = 'https://rstudio.r-universe.dev'))
+          try(install.packages('rmarkdown', repos = c('https://rstudio.r-universe.dev', getOption('repos'))))
+          try(install.packages('knitr', repos = c('https://yihui.r-universe.dev', getOption('repos'))))
+          if ('${{ inputs.extra-r-packages }}' != '') {
+            cat(sprintf("::notice::Running with the following extra R packages for pak: %s\n", "${{ inputs.extra-r-packages }}"))
+            renv::install(strsplit("${{ inputs.extra-r-packages }}", split = ",")[[1]])
+          }
         shell: Rscript {0}
         env:
           GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Show R session information
+        working-directory: tests
+        run: |
+          # Session info
+          cat("::group::Session info\n")
+          renv::install("sessioninfo")
+          sessioninfo::session_info(pkgs = "installed", include_base = TRUE)
+          cat("::endgroup::\n")
+        shell: Rscript {0}
+
       - name: Install uv for Python
         uses: astral-sh/setup-uv@v3
         with:
@@ -124,17 +147,16 @@ jobs:
           quarto install tinytex
 
       - name: Cache Typst packages
+        id: cache-typst
         uses: ./.github/actions/cache-typst
 
-      # - name: Install Chrome
-      #   uses: browser-actions/setup-chrome@v1
-      #   with:
-      #     chrome-version: 127
+      - name: Install Chrome
+        uses: browser-actions/setup-chrome@latest
 
       - name: Setup Julia
         uses: julia-actions/setup-julia@v2
         with:
-          version: "1.10"
+          version: "1.11.3"
 
       - name: Cache Julia Packages
         uses: julia-actions/cache@v2
@@ -148,29 +170,14 @@ jobs:
           export JUPYTER=$(find $(dirname $(uv run --frozen which jupyter))/ -type f -name "jupyter.exe" -o -name "jupyter")
           uv run --frozen julia --color=yes --project=. -e "import Pkg; Pkg.instantiate(); Pkg.build(\"IJulia\"); Pkg.precompile()"
           echo "Julia Jupyter:"
-          julia --project=. -e "import IJulia;println(IJulia.JUPYTER);println(IJulia.find_jupyter_subcommand(\"notebook\"))"
-
-      - name: Setup timing file for timed test
-        if: ${{ matrix.time-test == true }}
-        run: |
-          echo "QUARTO_TEST_TIMING=timing-for-ci.txt" >> "$GITHUB_ENV"
+          uv run julia --project=. -e "import IJulia;println(IJulia.JUPYTER);println(IJulia.find_jupyter_subcommand(\"notebook\"))"
 
       # - name: Setup tmate session
       #   uses: mxschmitt/action-tmate@v3
 
-      # The Check Chromium step appears necessary to avoid a crash/hang when rendering PDFs
-      # https://github.com/quarto-dev/quarto-actions/issues/45#issuecomment-1562599451
-      # Same fix as in quarto-actions/quarto-render
-      # chromium is installed in the ubuntu runners in GHA, so no need to install it
-      # - name: "Check Chromium"
-      #   if: ${{ runner.os == 'Linux' }}
-      #   run: |
-      #     echo $(which google-chrome)
-      #     $(which google-chrome) --headless --no-sandbox --disable-gpu --renderer-process-limit=1 https://www.chromestatus.com
-      #   shell: bash
-
+      # we run from tests directory as our environment for R, Python and Julia is set up there
       - name: Run all Smoke Tests Windows
-        if: ${{ runner.os == 'Windows' && format('{0}', inputs.buckets) == '' && matrix.time-test == false }}
+        if: ${{ runner.os == 'Windows' }}
         env:
           # Useful as TinyTeX latest release is checked in run-test.sh
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -179,10 +186,29 @@ jobs:
         shell: pwsh
 
       - name: Run all Smoke Tests Linux
-        if: ${{ runner.os != 'Windows' && format('{0}', inputs.buckets) == '' }}
+        if: ${{ runner.os != 'Windows' }}
         env:
           # Useful as TinyTeX latest release is checked in run-test.sh
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: shopt -s globstar && ./run-tests.sh ../dev-docs/feature-format-matrix/**/*.qmd
+        run: |
+          shopt -s globstar && 
+            ./run-tests.sh ../dev-docs/feature-format-matrix/**/*.qmd
         working-directory: tests
         shell: bash
+
+      - name: Save Typst cache
+        if: always() && steps.cache-typst.outputs.cache-hit != 'true'
+        uses: actions/cache/save@v4
+        with:
+          key: ${{ steps.cache-typst.outputs.cache-primary-key }}
+          path: ${{ steps.cache-typst.outputs.cache-path }}
+
+      - name: Save Renv package cache
+        # don't save cache if we have extra R packages
+        if: ${{ always() && steps.cache-renv-packages-restore.outputs.cache-hit != 'true' && inputs.extra-r-packages == '' }}
+        uses: actions/cache/save@v4
+        with:
+          path: |
+            ${{ env.RENV_PATHS_ROOT }}
+            renv/library
+          key: ${{ steps.cache-renv-packages-restore.outputs.cache-primary-key }}