include empty code cells. fixes #1034

Author: cscheid

src/core/lib/break-quarto-md.ts

@@ -71,14 +71,7 @@ export async function breakQuartoMd(
       | "directive",
     index: number,
   ) => {
-    if (lineBuffer.length) {
-      // TODO understand why was this here. This makes our line
-      // count computations wrong
-      //
-      // if (lineBuffer[lineBuffer.length - 1].substring === "") {
-      //   lineBuffer.splice(lineBuffer.length - 1, 1);
-      // }
-
+    if (lineBuffer.length || cell_type === "code") {
       const mappedChunks: Range[] = [];
       for (const line of lineBuffer) {
         mappedChunks.push(line.range);

tests/docs/break-quarto-md/github-issue-1034.qmd

@@ -0,0 +1,28 @@
+---
+execute:
+  echo: true
+---
+
+The original chunk:
+
+```{r}
+#| label: foo
+1 + 2
+```
+
+Using `ref.label` does not work with an empty body:
+
+```{r, ref.label = "foo"}
+```
+
+Using `ref.label` does work with a blank line body:
+
+```{r, ref.label = "foo"}
+
+```
+
+Using `<<...>>` noweb notation does work:
+
+```{r}
+<<foo>>
+```

tests/unit/break-quarto-md.test.ts renamed to tests/unit/break-quarto-md/break-quarto-md.test.ts

@@ -5,11 +5,24 @@
 *
 */
 
-import { breakQuartoMd } from "../../src/core/lib/break-quarto-md.ts";
-import { unitTest } from "../test.ts";
+import { breakQuartoMd } from "../../../src/core/lib/break-quarto-md.ts";
+import { unitTest } from "../../test.ts";
 import { assert } from "testing/asserts.ts";
+import { docs } from "../../utils.ts";
+import { initYamlIntelligenceResourcesFromFilesystem } from "../../../src/core/schema/utils.ts";
+
+unitTest("break-quarto-md - empty code cells", async () => {
+  await initYamlIntelligenceResourcesFromFilesystem();
+  const qmd = Deno.readTextFileSync(
+    docs("break-quarto-md/github-issue-1034.qmd"),
+  );
+
+  const result = await breakQuartoMd(qmd);
+  assert(result.cells.length === 9);
+});
 
 unitTest("break-quarto-md - indented code cells", async () => {
+  await initYamlIntelligenceResourcesFromFilesystem();
   const qmd = `---
 title: Blah
 ---
@@ -37,6 +50,7 @@ Blah blah
 });
 
 unitTest("break-quarto-md - math", async () => {
+  await initYamlIntelligenceResourcesFromFilesystem();
   const qmd = `---
 title: foo
 ---
@@ -56,6 +70,7 @@ Some more text;
 });
 
 unitTest("break-quarto-md - code", async () => {
+  await initYamlIntelligenceResourcesFromFilesystem();
   const qmd = `---
 title: mermaid test
 format: html
@@ -86,6 +101,7 @@ Do not touch this, please.
 });
 
 unitTest("break-quarto-md - nested code", async () => {
+  await initYamlIntelligenceResourcesFromFilesystem();
   const qmd = `---
 title: mermaid test
 format: html