call resolveEngines before looking for ignoreDirs

gordonwoodhull · claude · gordonwoodhull · commit ab899311c87a · 2025-12-15T18:56:05.000-05:00
this data is no longer static
and needs to consider engine extensions as well

website and default project tests

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/src/project/project-context.ts b/src/project/project-context.ts
@@ -63,6 +63,7 @@ import {
   fileExecutionEngine,
   fileExecutionEngineAndTarget,
   projectIgnoreGlobs,
+  resolveEngines,
 } from "../execute/engine.ts";
 import { ExecutionEngineInstance, kMarkdownEngine } from "../execute/types.ts";
 
@@ -884,6 +885,9 @@ async function projectInputFilesInternal(
   project: ProjectContext,
   metadata?: ProjectConfig,
 ): Promise<{ files: string[]; engines: string[] }> {
+  // Resolve engines so engineIgnoreDirs() uses all engines (including external)
+  await resolveEngines(project);
+
   const { dir } = project;
 
   const outputDir = metadata?.project[kProjectOutputDir];
diff --git a/tests/docs/project/ignore-dirs/.gitignore b/tests/docs/project/ignore-dirs/.gitignore
@@ -0,0 +1,3 @@
+/.quarto/
+**/*.quarto_ipynb
+*_files/
diff --git a/tests/docs/project/ignore-dirs/_quarto.yml b/tests/docs/project/ignore-dirs/_quarto.yml
@@ -0,0 +1,2 @@
+project:
+  type: default
diff --git a/tests/docs/project/ignore-dirs/index.qmd b/tests/docs/project/ignore-dirs/index.qmd
@@ -0,0 +1,5 @@
+---
+title: "Test Project"
+---
+
+This file should be rendered.
diff --git a/tests/docs/project/ignore-dirs/renv/test.qmd b/tests/docs/project/ignore-dirs/renv/test.qmd
@@ -0,0 +1,5 @@
+---
+title: "Renv Test"
+---
+
+This file should NOT be rendered (renv is a Knitr ignore directory).
diff --git a/tests/docs/project/ignore-dirs/venv/test.qmd b/tests/docs/project/ignore-dirs/venv/test.qmd
@@ -0,0 +1,5 @@
+---
+title: "Venv Test"
+---
+
+This file should NOT be rendered (venv is a Jupyter ignore directory).
diff --git a/tests/docs/websites/website-ignore-dirs/.gitignore b/tests/docs/websites/website-ignore-dirs/.gitignore
@@ -0,0 +1,4 @@
+/.quarto/
+**/*.quarto_ipynb
+*_files/
+_site/
diff --git a/tests/docs/websites/website-ignore-dirs/_quarto.yml b/tests/docs/websites/website-ignore-dirs/_quarto.yml
@@ -0,0 +1,13 @@
+project:
+  type: website
+
+website:
+  title: "Test Website"
+  navbar:
+    left:
+      - text: Home
+        file: index.qmd
+
+format:
+  html:
+    theme: default
diff --git a/tests/docs/websites/website-ignore-dirs/index.qmd b/tests/docs/websites/website-ignore-dirs/index.qmd
@@ -0,0 +1,5 @@
+---
+title: "Test Website"
+---
+
+This file should be rendered.
diff --git a/tests/docs/websites/website-ignore-dirs/renv/test.qmd b/tests/docs/websites/website-ignore-dirs/renv/test.qmd
@@ -0,0 +1,5 @@
+---
+title: "Renv Test"
+---
+
+This file should NOT be rendered (renv is a Knitr ignore directory).
diff --git a/tests/docs/websites/website-ignore-dirs/venv/test.qmd b/tests/docs/websites/website-ignore-dirs/venv/test.qmd
@@ -0,0 +1,5 @@
+---
+title: "Venv Test"
+---
+
+This file should NOT be rendered (venv is a Jupyter ignore directory).
diff --git a/tests/smoke/project/project-ignore-dirs.test.ts b/tests/smoke/project/project-ignore-dirs.test.ts
@@ -0,0 +1,46 @@
+/*
+ * project-ignore-dirs.test.ts
+ *
+ * Verifies that engine-specific ignore directories (venv, renv, env, packrat, etc.)
+ * are properly excluded from project file discovery and rendering.
+ *
+ * Copyright (C) 2020-2025 Posit Software, PBC
+ */
+
+import { docs } from "../../utils.ts";
+import { join } from "../../../src/deno_ral/path.ts";
+import { existsSync } from "../../../src/deno_ral/fs.ts";
+import { testQuartoCmd } from "../../test.ts";
+import { fileExists, noErrors, pathDoNotExists } from "../../verify.ts";
+
+const renderDir = docs("project/ignore-dirs");
+const outDir = join(Deno.cwd(), renderDir);
+
+// Test that engine ignore directories are properly excluded
+testQuartoCmd(
+  "render",
+  [renderDir],
+  [
+    noErrors,
+    fileExists(join(outDir, "index.html")),              // Control: regular file should be rendered
+    pathDoNotExists(join(outDir, "venv", "test.html")),  // venv (Jupyter) should be ignored
+    pathDoNotExists(join(outDir, "renv", "test.html")),  // renv (Knitr) should be ignored
+    pathDoNotExists(join(outDir, "env", "test.html")),   // env (Jupyter) should be ignored
+  ],
+  {
+    teardown: async () => {
+      // Clean up rendered HTML files
+      const htmlFiles = [
+        join(outDir, "index.html"),
+        join(outDir, "venv", "test.html"),
+        join(outDir, "renv", "test.html"),
+        join(outDir, "env", "test.html"),
+      ];
+      for (const file of htmlFiles) {
+        if (existsSync(file)) {
+          await Deno.remove(file);
+        }
+      }
+    },
+  },
+);
diff --git a/tests/smoke/website/website-ignore-dirs.test.ts b/tests/smoke/website/website-ignore-dirs.test.ts
@@ -0,0 +1,37 @@
+/*
+ * website-ignore-dirs.test.ts
+ *
+ * Verifies that engine-specific ignore directories (venv, renv, env, packrat, etc.)
+ * are properly excluded from website file discovery and rendering.
+ *
+ * Copyright (C) 2020-2025 Posit Software, PBC
+ */
+
+import { docs } from "../../utils.ts";
+import { join } from "../../../src/deno_ral/path.ts";
+import { existsSync } from "../../../src/deno_ral/fs.ts";
+import { testQuartoCmd } from "../../test.ts";
+import { fileExists, noErrors, pathDoNotExists } from "../../verify.ts";
+
+const renderDir = docs("websites/website-ignore-dirs");
+const outDir = join(Deno.cwd(), renderDir, "_site");
+
+// Test that engine ignore directories are properly excluded
+testQuartoCmd(
+  "render",
+  [renderDir],
+  [
+    noErrors,
+    fileExists(join(outDir, "index.html")),              // Control: regular file should be rendered
+    pathDoNotExists(join(outDir, "venv", "test.html")),  // venv (Jupyter) should be ignored
+    pathDoNotExists(join(outDir, "renv", "test.html")),  // renv (Knitr) should be ignored
+    pathDoNotExists(join(outDir, "env", "test.html")),   // env (Jupyter) should be ignored
+  ],
+  {
+    teardown: async () => {
+      if (existsSync(outDir)) {
+        await Deno.remove(outDir, { recursive: true });
+      }
+    },
+  },
+);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+/.quarto/`
	`2`	`+*/.quarto_ipynb`
	`3`	`+*_files/`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +title: "Test Project"
 +---
++
 +This file should be rendered.