Merge pull request #3853 from quarto-dev/fix/theorem-vertical-space

Remove id on theorems Divs so that Pandoc does not insert raw Latex for us

Author: dragonstyle

news/changelog-1.3.md

@@ -36,6 +36,7 @@
 - Add support for automatically converting SVG images to PDF ([#2575](https://github.com/quarto-dev/quarto-cli/issues/2575))
 - Previously, if the `pdf-engine` was set to `latexmk`, we would bypass many features of Quarto and use Pandoc to produce the PDF output. Starting in in Quarto 1.3, all Quarto features will be enabled for the `latexmk` engine and `latexmk` will be used to run the PDF generation loop.
 - Fix author processing in default PDFs for complex author names (#3483)
+- Remove excessive vertical space between theorem type blocks ([#3776](https://github.com/quarto-dev/quarto-cli/issues/3776)).
 
 ## Beamer Format
 

src/resources/filters/crossref/theorems.lua

@@ -63,12 +63,14 @@ function crossrefTheorems()
           end
           preamble.content:insert(pandoc.RawInline("latex", "]"))
           preamble.content:insert(pandoc.RawInline("latex",
-            "\\label{" .. label .. "}")
+            "\\protect\\hypertarget{" .. label .. "}{}\\label{" .. label .. "}")
           )
           el.content:insert(1, preamble)
           el.content:insert(pandoc.Para(pandoc.RawInline("latex", 
             "\\end{" .. theoremType.env .. "}"
           )))
+          -- Remove id on those div to avoid Pandoc inserting \hypertaget #3776
+          el.attr.identifier = ""
         elseif _quarto.format.isJatsOutput() then
 
           -- JATS XML theorem

tests/smoke/crossref/latex.test.ts

@@ -32,16 +32,22 @@ const subTableRegexes = [
 ];
 
 const theoremRegexes = [
-  /\\begin{theorem}[^]*?\\label{thm-line}[^]*?\\end{theorem}/,
+  /\\begin{theorem}[^]*?\\protect\\hypertarget{thm-line}{}\\label{thm-line}[^]*?\\end{theorem}/,
   /Theorem~\\ref{thm-line}/,
 ];
 
+const theoremRegexesNo = [
+  /\\leavevmode\\vadjust pre{\\hypertarget{thm-line}{}}%/,
+];
+
 testRender(allQmd.input, "latex", true, [
   ensureFileRegexMatches(allQmd.output.outputPath, [
     ...simpleFigRegexes,
     ...subFigRegexes,
     ...simpleTableRegexes,
     ...subTableRegexes,
     ...theoremRegexes,
+  ], [
+    ...theoremRegexesNo,
   ]),
 ]);