Skip to content

Commit babee58

Browse files
committed
cri - use none for no flag value as "" will be undefined in Deno
at least for Windows
1 parent a2806f5 commit babee58

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

news/changelog-1.6.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ All changes included in 1.6:
103103

104104
## Chromium support
105105

106-
- ([#11135](https://github.com/quarto-dev/quarto-cli/issues/11135)): Use `--headless=old` mode for Chromium to avoid recent issues with the new `--headless` mode. Setting `--headless=new` can be configured with `QUARTO_CHROMIUM_HEADLESS_MODE=new` environment variable, however it is not recommended new headless mode seems to be unstable. Only use to be unblocked of a situation (like `QUARTO_CHROMIUM_HEADLESS_MODE=""` if you use a old chrome version somehow).
106+
- ([#11135](https://github.com/quarto-dev/quarto-cli/issues/11135)): Use `--headless=old` mode for Chromium to avoid recent issues with the new `--headless` mode. Setting `--headless=new` can be configured with `QUARTO_CHROMIUM_HEADLESS_MODE=new` environment variable, however it is not recommended new headless mode seems to be unstable. Only use to be unblocked of a situation (like `QUARTO_CHROMIUM_HEADLESS_MODE="none"` if you use a old chrome version somehow that don't support `--headless=old`).
107107
- ([#10170](https://github.com/quarto-dev/quarto-cli/issues/10170)): Quarto should find chrome executable automatically on most OS. If this is does not find it, or a specific version is needed, set `QUARTO_CHROMIUM` environment variable to the executable path.
108108

109109
## Other Fixes and Improvements

src/core/cri/cri.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export async function criClient(appPath?: string, port?: number) {
9393
// move to the new mode. We'll use `--headless=old` as the default for now
9494
// until the new mode is more stable, or until we really pin a version as default to be used.
9595
// This is also impacting in chromote and pagedown R packages and we could keep syncing with them.
96-
`--headless${headlessMode ? "=" + headlessMode : ""}`,
96+
`--headless${headlessMode == "none" ? "" : "=" + headlessMode}`,
9797
"--no-sandbox",
9898
"--disable-gpu",
9999
"--renderer-process-limit=1",

0 commit comments

Comments
 (0)