Merge pull request #11674 from quarto-dev/lightbox-improvment

Author: cderv

news/changelog-1.7.md

@@ -11,6 +11,10 @@ All changes included in 1.7:
 
 - ([#11654](https://github.com/quarto-dev/quarto-cli/issues/11654)): Allow `page-inset` as value in `column` key for code cells.
 
+## Book Project
+
+- ([#11520](https://github.com/quarto-dev/quarto-cli/issues/11520)): Book's cover image now escapes lightbox treatment, which was incorrectly applied to it when `lightbox: true` was set in the book's configuration.
+
 ## `quarto check`
 
 - ([#11608](https://github.com/quarto-dev/quarto-cli/pull/11608)): Do not issue error message when calling `quarto check info`.

src/project/types/book/book-render.ts

@@ -173,7 +173,7 @@ export function bookPandocRenderer(
             const title = file.recipe.format.metadata[kTitle] || "";
             const alt = coverImageAlt ? ` fig-alt="${coverImageAlt}"` : "";
             file.executeResult.markdown =
-              `![](${coverImage} "${title}"){.quarto-cover-image${alt}}\n\n` +
+              `![](${coverImage} "${title}"){.quarto-cover-image .nolightbox${alt}}\n\n` +
               file.executeResult.markdown;
           }
 

tests/docs/smoke-all/2024/12/12/11520/.gitignore

@@ -0,0 +1,2 @@
+/.quarto/
+/_book/

tests/docs/smoke-all/2024/12/12/11520/_quarto.yml

@@ -0,0 +1,16 @@
+project:
+  type: book
+
+book:
+  title: "mybook"
+  author: "Norah Jones"
+  date: "11/24/2024"
+  cover-image: cover.png
+  chapters:
+    - index.qmd
+
+format:
+  html:
+    theme: cosmo
+
+lightbox: true

tests/docs/smoke-all/2024/12/12/11520/cover.png

@@ -0,0 +1,14 @@
+---
+_quarto:
+  tests:
+    html:
+      ensureHtmlElements:
+        - ['section#preface .quarto-cover-image']
+        - ['.ligtbox > .quarto-cover-image']
+---
+
+# Preface {.unnumbered}
+
+This is a Quarto book. Cover image should not have Lightbox treatment in books when `lightbox: true`
+
+To learn more about Quarto books visit <https://quarto.org/docs/books>.