assert success with debug info in failure case

Author: jkrumbiegel

tests/smoke/call/engine/julia/julia.test.ts

@@ -6,13 +6,22 @@ import { juliaTransportFile } from "../../../../../src/execute/julia.ts";
 const sleepQmd = docs("call/engine/julia/sleep.qmd");
 assert(existsSync(sleepQmd));
 
+function assertSuccess(output: Deno.CommandOutput) {
+  if (!output.success) {
+    console.error("Command failed:");
+    console.error("stdout:\n" + new TextDecoder().decode(output.stdout));
+    console.error("stderr:\n" + new TextDecoder().decode(output.stderr));
+    throw new Error("Command execution was not successful");
+  }
+}
+
 // make sure we don't have a server process running by sending a kill command
 // and then also try to remove the transport file in case one still exists
 const killcmd = new Deno.Command(
   quartoDevCmd(),
   {args: ["call", "engine", "julia", "kill"]}
 ).outputSync();
-assert(killcmd.success);
+assertSuccess(killcmd);
 try {
   await Deno.remove(juliaTransportFile());
 } catch {
@@ -23,7 +32,7 @@ Deno.test("kill without server running", () => {
     quartoDevCmd(),
     {args: ["call", "engine", "julia", "kill"]}
   ).outputSync();
-  assert(output.success);
+  assertSuccess(output);
   const stderr = new TextDecoder().decode(output.stderr);
   assertStringIncludes(stderr, "Julia control server is not running.");
 });
@@ -33,7 +42,7 @@ Deno.test("status without server running", () => {
     quartoDevCmd(),
     {args: ["call", "engine", "julia", "status"]}
   ).outputSync();
-  assert(output.success);
+  assertSuccess(output);
   const stderr = new TextDecoder().decode(output.stderr);
   assertStringIncludes(stderr, "Julia control server is not running.");
 });
@@ -43,17 +52,16 @@ Deno.test("status with server and worker running", () => {
     quartoDevCmd(),
     {args: ["render", sleepQmd, "-P", "sleep_duration:0", "--execute-daemon", "60"]}
   ).outputSync();
-  assert(render_output.success);
+  assertSuccess(render_output);
 
   const status_output = new Deno.Command(
     quartoDevCmd(),
     {args: ["call", "engine", "julia", "status"]}
   ).outputSync();
+  assertSuccess(status_output);
   const stdout = new TextDecoder().decode(status_output.stdout);
-  console.log(stdout);
-  const stderr = new TextDecoder().decode(status_output.stderr);
-  console.log(stderr);
   assert(status_output.success);
+
   assertStringIncludes(stdout, "workers active: 1");
 });
 
@@ -62,7 +70,7 @@ Deno.test("log exists", () => {
     quartoDevCmd(),
     {args: ["call", "engine", "julia", "log"]}
   ).outputSync();
-  assert(log_output.success);
+  assertSuccess(log_output);
   const stdout_log = new TextDecoder().decode(log_output.stdout);
   assertStringIncludes(stdout_log, "Log started at");
 });