Merge pull request #1041 from cderv/code-line-number-knitr

[knitr] Correctly handle code-line-numbers=false in R chunk

Author: jjallaire

src/resources/rmd/hooks.R

@@ -380,7 +380,7 @@ knitr_hooks <- function(format, resourceDir, handledLanguages) {
     }
     lineNumbers <- options[["code-line-numbers"]]
     if (!is.null(lineNumbers)) {
-      attr <- paste(attr, paste0('code-line-numbers="', as.character(lineNumbers), '"'))
+      attr <- paste(attr, paste0('code-line-numbers="', tolower(as.character(lineNumbers)), '"'))
     }
 
     lang <- tolower(options$engine)

tests/docs/code-highlighting/code-line-number-knitr.qmd

@@ -0,0 +1,21 @@
+---
+title: "Plot Test"
+format: html
+code-line-numbers: true
+knitr:
+  opts_chunk: 
+      eval: false
+---
+
+# with line number comment {#with-numbering}
+
+```{r}
+1 + 2
+```
+
+# no line number comment {#no-numbering}
+
+```{r}
+#| code-line-numbers: false
+1 + 2
+```

tests/smoke/render/render-code-highlighting.test.ts

@@ -0,0 +1,22 @@
+/*
+* render-r.test.ts
+*
+* Copyright (C) 2020 by RStudio, PBC
+*
+*/
+
+import { fileLoader } from "../../utils.ts";
+import { ensureHtmlElements } from "../../verify.ts";
+import { testRender } from "./render.ts";
+
+const doc = fileLoader("code-highlighting")(
+  "code-line-number-knitr.qmd",
+  "html",
+);
+testRender(doc.input, "html", false, [
+  ensureHtmlElements(
+    doc.output.outputPath,
+    ["#with-numbering div.cell-code > pre.number-lines"],
+    ["#no-numbering div.cell-code > pre.number-lines"],
+  ),
+]);