Skip to content

Commit e05aa7f

Browse files
authored
Merge branch 'main' into typst/template-update
2 parents 9a72979 + 164df8b commit e05aa7f

File tree

14 files changed

+106
-5
lines changed

14 files changed

+106
-5
lines changed

news/changelog-1.9.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,17 @@ All changes included in 1.9:
1414
### `typst`
1515

1616
- ([#13362](https://github.com/quarto-dev/quarto-cli/issues/13362)): Remove unused `blockquote` definitions from template.
17+
18+
### `gfm`
19+
20+
- ([#13421](https://github.com/quarto-dev/quarto-cli/issues/13421)): Do not word-wrap titles in header.
21+
22+
### `html`
23+
24+
- ([#13413](https://github.com/quarto-dev/quarto-cli/issues/13413)): Fix uncentered play button in `video` shortcodes from cross-reference divs. (author: @bruvellu)
25+
26+
## `publish`
27+
28+
### Confluence
29+
30+
- ([#13414](https://github.com/quarto-dev/quarto-cli/issues/13414)): Be more forgiving when Confluence server returns malformed JSON response. (author: @m1no)

src/core/brand/brand.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ export class Brand {
259259
getLogoResource(name: string): BrandLogoExplicitResource {
260260
const entry = this.data.logo?.images?.[name];
261261
if (!entry) {
262-
return { path: name };
262+
return this.resolvePath(name);
263263
}
264264
return this.resolvePath(entry);
265265
}

src/publish/confluence/api/index.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,10 +381,19 @@ export class ConfluenceClient {
381381
};
382382
}
383383

384-
private handleResponse<T>(response: Response) {
384+
private async handleResponse<T>(response: Response) {
385385
if (response.ok) {
386386
if (response.body) {
387-
return response.json() as unknown as T;
387+
// Some Confluence API endpoints return successfull calls with no body while using content-type "application/json"
388+
// example: https://developer.atlassian.com/cloud/confluence/rest/v1/api-group-content-restrictions/#api-wiki-rest-api-content-id-restriction-byoperation-operationkey-bygroupid-groupid-get
389+
// To prevent JSON parsing errors we have to return null for empty bodies and only parse when there is content
390+
let data = await response.text();
391+
392+
if (data === "") {
393+
return null as unknown as T;
394+
} else {
395+
return JSON.parse(data) as unknown as T;
396+
}
388397
} else {
389398
return response as unknown as T;
390399
}

src/resources/extensions/quarto/video/video.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ local videoJSBuilder = function(params)
160160
VIDEO_SHORTCODE_NUM_VIDEOJS = VIDEO_SHORTCODE_NUM_VIDEOJS + 1
161161
local id = "video_shortcode_videojs_video" .. VIDEO_SHORTCODE_NUM_VIDEOJS
162162

163-
local SNIPPET = [[<video id="{id}"{width}{height} class="video-js vjs-default-skin {fluid}" controls preload="auto" data-setup='{}' title="{title}"><source src="{src}"></video>]]
163+
local SNIPPET = [[<video id="{id}"{width}{height} class="video-js vjs-default-skin vjs-big-play-centered {fluid}" controls preload="auto" data-setup='{}' title="{title}"><source src="{src}"></video>]]
164164
local snippet = params.snippet or SNIPPET
165165
snippet = replaceCommonAttributes(snippet, params)
166166
snippet = interpolate {

src/resources/pandoc/templates/default.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
$if(title)$
2-
# $title$
2+
# $title/nowrap$
33
$endif$
44
$for(by-author)$$it.name.literal$$sep$, $endfor$
55
$if(date)$
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
format: gfm
3+
title: "0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789"
4+
_quarto:
5+
tests:
6+
gfm:
7+
ensureFileRegexMatches:
8+
- []
9+
- ["\n012345"]
10+
---
11+
12+
Do not wrap.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
logo:
2+
medium: ../logos/logo.png
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
format:
3+
dashboard: default
4+
revealjs: default
5+
typst:
6+
keep-typ: true
7+
brand: brand/_brand.yml
8+
_quarto:
9+
tests:
10+
dashboard:
11+
ensureFileRegexMatches:
12+
-
13+
- '<img src="logos(/|\\)logo.png"'
14+
- []
15+
revealjs:
16+
ensureFileRegexMatches:
17+
-
18+
- '<img src="logos(/|\\)logo.png"'
19+
- []
20+
typst:
21+
ensureTypstFileRegexMatches:
22+
-
23+
- 'background: align\(left\+top, box\(inset: 0\.75in, image\("logos(/|\\\\)logo\.png", width: 1\.5in\)\)'
24+
- []
25+
---
26+
27+
# Test
28+
29+
Some text
11.5 KB
Loading
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
/.quarto/
2+
**/*.quarto_ipynb

0 commit comments

Comments
 (0)