Image in mediabag needs to be written in binary mode (#3995)

fixes #3982

Author: cderv

.github/workflows/test-smokes.yml

@@ -88,6 +88,8 @@ jobs:
 
       - name: Smoke Test Commits
         if: github.event.before != ''
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           git checkout ${{ github.sha}}
           pushd tests

news/changelog-1.3.md

@@ -42,6 +42,7 @@
 - Remove excessive vertical space between theorem type blocks ([#3776](https://github.com/quarto-dev/quarto-cli/issues/3776)).
 - Fix temporary `.tex` filenames in the presence of multiple variants ([#3762](https://github.com/quarto-dev/quarto-cli/issues/3762)).
   - Note that this fix changes the filenames used for PDF files with variants. In quarto 1.3, the automatic output names for PDF files include format variants and modifiers.
+- Correctly download online image on Windows ([#3982](https://github.com/quarto-dev/quarto-cli/issues/3982)).
 
 ## Beamer Format
 

src/resources/pandoc/datadir/init.lua

@@ -1744,10 +1744,12 @@ local function file_exists(name)
      return false
    end
  end
- 
- local function write_file(path, contents)
+
+
+ local function write_file(path, contents, mode)
    pandoc.system.make_directory(pandoc.path.directory(path), true)
-   local file = io.open(path, "a")
+   mode = mode or "a"
+   local file = io.open(path, mode)
    if file then
      file:write(contents)
      file:close()
@@ -1789,7 +1791,12 @@ _quarto = {
    projectOffset = projectOffset,
    file = {
       read = read_file,
-      write = write_file,
+      write = function(path, contents) 
+         return write_file(path, contents, "wb") 
+      end,
+      write_text = function(path, contents) 
+         return write_file(path, contents, "a")
+      end,
       exists = file_exists,
       remove = remove_file
    }

tests/docs/smoke-all/2023/01/17/online-image-mediabag.qmd

@@ -0,0 +1,17 @@
+---
+title: "Penguins, meet Quarto!"
+format: pdf
+keep-tex: true
+_quarto:
+  tests:
+    pdf:
+      noErrors: default
+      fileExists: 
+        supportPath: mediabag/lter_penguins.png
+---
+
+## Meet the penguins
+
+![](https://raw.githubusercontent.com/quarto-dev/quarto-web/main/docs/get-started/hello/rstudio/lter_penguins.png){style="float:right;" fig-alt="Illustration of three species of Palmer Archipelago penguins: Chinstrap, Gentoo, and Adelie. Artwork by @allison_horst." width="401"}
+
+

tests/smoke/smoke-all.test.ts

@@ -7,7 +7,6 @@
 
 import { expandGlobSync } from "../../src/core/deno/expand-glob.ts";
 import { testQuartoCmd, Verify } from "../test.ts";
-
 import { initYamlIntelligenceResourcesFromFilesystem } from "../../src/core/schema/utils.ts";
 import {
   initState,
@@ -21,13 +20,15 @@ import {
   ensureDocxRegexMatches,
   ensureFileRegexMatches,
   ensureHtmlElements,
+  fileExists,
   noErrors,
   noErrorsOrWarnings,
 } from "../verify.ts";
 import { readYamlFromMarkdown } from "../../src/core/yaml.ts";
 import { outputForInput } from "../utils.ts";
 import { jupyterToMarkdown } from "../../src/core/jupyter/jupyter.ts";
 import { jupyterNotebookToMarkdown } from "../../src/command/convert/jupyter.ts";
+import { dirname, join } from "path/mod.ts";
 
 async function fullInit() {
   await initYamlIntelligenceResourcesFromFilesystem();
@@ -99,8 +100,24 @@ function resolveTestSpecs(
           checkWarnings = false;
           verifyFns.push(noErrors);
         } else {
-          if (verifyMap[key]) {
-            const outputFile = outputForInput(input, format);
+          const outputFile = outputForInput(input, format);
+          if (key === "fileExists") {
+            for (
+              const [path, file] of Object.entries(
+                value as Record<string, string>,
+              )
+            ) {
+              if (path === "outputPath") {
+                verifyFns.push(
+                  fileExists(join(dirname(outputFile.outputPath), file)),
+                );
+              } else if (path === "supportPath") {
+                verifyFns.push(
+                  fileExists(join(outputFile.supportPath, file)),
+                );
+              }
+            }
+          } else if (verifyMap[key]) {
             verifyFns.push(verifyMap[key](outputFile.outputPath, ...value));
           }
         }