Commit e5ed82b
authored
* Do not override the knitr's `embed` engine with internal quarto's `embed` handler
Currently the `embed` handler is only for Jupyter.
Discovered while looking at #4712 - revealjs does not work with knitr embed engine
* Set echo = TRUE for embed and verbatim engine when revealjs
because those engine expect echo, but revealjs default to FALSE
* Add embed to ignored engine for chunk hook
* Add test for knitr revealjs fix regarding verbatim and embed
* Revert "Do not override the knitr's `embed` engine with internal quarto's `embed` handler"
This reverts commit 53d8703.
* Internal languages are only handlers of type cell
Other language are shortcodes
* For embed and verbatim engine, always set to TRUE
This will avoid format defaulting to echo: false to hide those chunks
1 parent 7e62b54 commit e5ed82b
File tree
4 files changed
+44
-4
lines changed- src
- core/handlers
- resources/rmd
- tests/docs/smoke-all/2023/03/09
4 files changed
+44
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
| 282 | + | |
282 | 283 | | |
283 | | - | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
284 | 291 | | |
285 | 292 | | |
286 | 293 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
47 | 52 | | |
48 | 53 | | |
49 | 54 | | |
| |||
162 | 167 | | |
163 | 168 | | |
164 | 169 | | |
165 | | - | |
166 | | - | |
167 | | - | |
| 170 | + | |
| 171 | + | |
168 | 172 | | |
169 | 173 | | |
170 | 174 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
Lines changed: 28 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
0 commit comments