Merge pull request #9784 from quarto-dev/fix/margin-sidebar-toggle

cderv · web-flow · commit e7741a4aa186 · 2024-05-28T13:05:42.000+02:00
diff --git a/news/changelog-1.5.md b/news/changelog-1.5.md
@@ -57,6 +57,7 @@ All changes included in 1.5:
 - ([#8851](https://github.com/quarto-dev/quarto-cli/issues/8851)): Don't strip `index.html` from external paths.
 - ([#8977](https://github.com/quarto-dev/quarto-cli/issues/8977)): Don't decorate about links within external link icons.
 - ([#9356](https://github.com/quarto-dev/quarto-cli/issues/9356)): Don't process column classes for figures inside the About divs.
+- ([#9781](https://github.com/quarto-dev/quarto-cli/issues/9781)): Correctly hide elements from click event in collapsed margin sidebar.
 
 ## Book
 
diff --git a/src/resources/formats/html/quarto.js b/src/resources/formats/html/quarto.js
@@ -319,6 +319,7 @@ window.document.addEventListener("DOMContentLoaded", function (_event) {
           for (const child of el.children) {
             child.style.opacity = 0;
             child.style.overflow = "hidden";
+            child.style.pointerEvents = "none";
           }
 
           nexttick(() => {
@@ -360,6 +361,7 @@ window.document.addEventListener("DOMContentLoaded", function (_event) {
 
               const clone = child.cloneNode(true);
               clone.style.opacity = 1;
+              clone.style.pointerEvents = null;
               clone.style.display = null;
               toggleContents.append(clone);
             }
@@ -434,6 +436,7 @@ window.document.addEventListener("DOMContentLoaded", function (_event) {
           for (const child of el.children) {
             child.style.opacity = 1;
             child.style.overflow = null;
+            child.style.pointerEvents = null;
           }
 
           const placeholderEl = window.document.getElementById(

Original file line number	Diff line number	Diff line change
`@@ -319,6 +319,7 @@ window.document.addEventListener("DOMContentLoaded", function (_event) {`
`319`	`319`	`for (const child of el.children) {`
`320`	`320`	`child.style.opacity = 0;`
`321`	`321`	`child.style.overflow = "hidden";`
	`322`	`+ child.style.pointerEvents = "none";`
`322`	`323`	`}`
`323`	`324`
`324`	`325`	`nexttick(() => {`
`@@ -360,6 +361,7 @@ window.document.addEventListener("DOMContentLoaded", function (_event) {`
`360`	`361`
`361`	`362`	`const clone = child.cloneNode(true);`
`362`	`363`	`clone.style.opacity = 1;`
	`364`	`+ clone.style.pointerEvents = null;`
`363`	`365`	`clone.style.display = null;`
`364`	`366`	`toggleContents.append(clone);`
`365`	`367`	`}`
`@@ -434,6 +436,7 @@ window.document.addEventListener("DOMContentLoaded", function (_event) {`
`434`	`436`	`for (const child of el.children) {`
`435`	`437`	`child.style.opacity = 1;`
`436`	`438`	`child.style.overflow = null;`
	`439`	`+ child.style.pointerEvents = null;`
`437`	`440`	`}`
`438`	`441`
`439`	`442`	`const placeholderEl = window.document.getElementById(`