Use pandoc pipe

Author: dragonstyle

news/changelog-1.3.md

@@ -18,6 +18,7 @@
 
 - Fix wrong page number in the TOC for appendices ([#3164](https://github.com/quarto-dev/quarto-cli/issues/3164)) (Thank you, @iusgit!)
 - Add support for automatically converting SVG images to PDF ([#2575](https://github.com/quarto-dev/quarto-cli/issues/2575))
+- Previously, if the `pdf-engine` was set to `latexmk`, we would bypass many features of Quarto and use Pandoc to produce the PDF output. Starting in in Quarto 1.3, all Quarto features will be enabled for the `latexmk` engine and `latexmk` will be used to run the PDF generation loop.
 
 ## Beamer Format
 

src/resources/filters/quarto-post/pdf-images.lua

@@ -4,12 +4,19 @@
 local function convert_svg(path)
   local stem = pandoc.path.split_extension(path)
   local output = stem .. '.pdf'
-  local result = os.execute("rsvg-convert -f pdf -a -o" .. output .. " " .. path)
-  if result then
+
+  local status, results = pcall(pandoc.pipe, "rsvg-convert", {"-f", "pdf", "-a", "-o", output, path}, "")
+  if status then
     return output
   else 
-    error("Failed when attempting to convert a SVG to a PDF for output. Please ensure that rsvg-convert is available on the path.")
-    os.exit(1)
+    if results['command'] == nil then
+      -- command not found
+      error("Failed when attempting to convert a SVG to a PDF for output. Please ensure that rsvg-convert is available on the path.")
+      os.exit(1)
+    else
+      error("Failed when attempting to convert a SVG to a PDF for output. An error occurred while attempting to run rsvg-convert.\nError code " .. tostring(results['error_code']) )
+      os.exit(1)
+    end
   end
 end