Skip to content

Commit fafd9de

Browse files
authored
Merge branch 'main' into dependencies/1.8-mermaidjs
2 parents 43e5300 + b543849 commit fafd9de

File tree

8 files changed

+2032
-1992
lines changed

8 files changed

+2032
-1992
lines changed

news/changelog-1.8.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ All changes included in 1.8:
2020
- ([#12747](https://github.com/quarto-dev/quarto-cli/issues/12747)): Ensure `th` elements are properly restored when Quarto's HTML table processing is happening.
2121
- ([#12766](https://github.com/quarto-dev/quarto-cli/issues/12766)): Use consistent equation numbering display for `html-math-method` and `html-math-method.method` for MathJax and KaTeX (author: @mcanouil)
2222
- ([#12797](https://github.com/quarto-dev/quarto-cli/issues/12797)): Allow light and dark brands to be specified in one file, by specializing colors with `light:` and `dark:`.
23+
- ([#12919](https://github.com/quarto-dev/quarto-cli/issues/12919)): Ensure `kbd` shortcode output has hover tooltip.
2324

2425
### `revealjs`
2526

@@ -51,6 +52,7 @@ All changes included in 1.8:
5152
- ([#12551](https://github.com/quarto-dev/quarto-cli/pull/12551)): Improve warning issued when `aliases` would overwrite an existing document.
5253
- ([#12616](https://github.com/quarto-dev/quarto-cli/issues/12616)): find SVG images in image discovery for listings.
5354
- ([#12693](https://github.com/quarto-dev/quarto-cli/issues/12693)): Prevent resource exhaustion on large websites by serializing `NotebookContext` information to file instead of the environment.
55+
- ([#12949](https://github.com/quarto-dev/quarto-cli/issues/12949)): Ensure redirects preserve `hash` and `search` when possible.
5456

5557
## Crossrefs
5658

@@ -68,6 +70,10 @@ All changes included in 1.8:
6870

6971
- ([#12733](https://github.com/quarto-dev/quarto-cli/issues/12733)): Add installed extensions to `quarto inspect` project report.
7072

73+
### `add`
74+
75+
- ([#12627](https://github.com/quarto-dev/quarto-cli/issues/12627)): Don't actually install extension when user responds `yes` to first prompt but `no` to second.
76+
7177
## Engines
7278

7379
### `jupyter`

src/extension/install.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ export async function installExtension(
7878
if (!confirmed) {
7979
// Not confirmed, cancel the installation
8080
cancelInstallation();
81+
return false;
8182
}
8283

8384
// Complete the installation

src/resources/extensions/quarto/kbd/kbd.lua

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ return {
1313
stylesheets = { 'resources/kbd.css' }
1414
})
1515
local kwargs_strs = {}
16+
local title_strs = {}
1617
for k, v in pairs(kwargs) do
1718
table.insert(kwargs_strs, string.format('data-%s="%s"', osname(k), pandoc.utils.stringify(v)))
19+
table.insert(title_strs, osname(k) .. ': ' .. pandoc.utils.stringify(v))
1820
end
1921
table.sort(kwargs_strs) -- sort so that the output is deterministic
2022
local kwargs_str = table.concat(kwargs_strs)
@@ -29,9 +31,14 @@ return {
2931
default_arg_str = ""
3032
else
3133
default_arg_str = pandoc.utils.stringify(args[1])
34+
table.insert(title_strs, default_arg_str)
3235
end
33-
34-
return pandoc.RawInline('html', '<kbd aria-hidden="true" ' .. kwargs_str .. '>' .. default_arg_str .. '</kbd><span class="visually-hidden">' .. default_arg_str .. '</span>')
36+
table.sort(title_strs) -- sort so that the output is deterministic
37+
local title_str = table.concat(title_strs, ', ')
38+
if title_str == "" then
39+
title_str = default_arg_str
40+
end
41+
return pandoc.RawInline('html', '<kbd title="' .. title_str .. '" aria-hidden="true" ' .. kwargs_str .. '>' .. default_arg_str .. '</kbd><span class="visually-hidden">' .. default_arg_str .. '</span>')
3542
elseif quarto.doc.isFormat("asciidoc") then
3643
if args and #args == 1 then
3744
-- https://docs.asciidoctor.org/asciidoc/latest/macros/keyboard-macro/

src/resources/projects/website/templates/redirect-map.ejs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
var hash = window.location.hash.startsWith('#') ? window.location.hash.slice(1) : window.location.hash;
88
var redirect = redirects[hash] || redirects[""] || "/";
99
window.document.title = 'Redirect to ' + redirect;
10+
if (!redirects[hash]) {
11+
redirect = redirect + window.location.hash;
12+
}
13+
redirect = redirect + window.location.search;
1014
window.location.replace(redirect);
1115
</script>
1216
</head>

src/webui/quarto-preview/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/webui/quarto-preview/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"dev": "tsc --noEmit && vite build --mode=development"
1919
},
2020
"dependencies": {
21-
"@fluentui/react-icons": "^2.0.300",
21+
"@fluentui/react-icons": "^2.0.301",
2222
"@fluentui/react-components": "~9.48.0",
2323
"react": "^18.2.0",
2424
"react-dom": "^18.2.0",
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
format: html
3+
_quarto:
4+
tests:
5+
html:
6+
ensureHtmlElements:
7+
- ['kbd[title="Shift-K"]','kbd[title="linux: Shift-Ctrl-L, mac: Shift-Command-O, windows: Shift-Control-O"]']
8+
---
9+
10+
{{< kbd mac=Shift-Command-O win=Shift-Control-O linux=Shift-Ctrl-L >}}
11+
12+
{{< kbd Shift-K >}}

0 commit comments

Comments
 (0)