Why jupyterlab-quarto 0.1.45 is hard coded

[rgaiacs]

Description

A colleague of mine has a Jupyter Notebook on mybinder.org that some Markdown cells are show with wrong height when loaded. After some debugging, we identified the source of the problem to the package jupyterlab-quarto version 0.1.45 that is installed when using

quarto use binder

The version 0.1.45 is hard coded in

quarto-cli/src/command/use/commands/binder/binder.ts

Line 403 in 7ca42c0

pythonConfig.pip?.push("jupyterlab-quarto==0.1.45");

@dragonstyle why is the version hard coded?

I believe that https://github.com/jupyterhub/repo2docker is now using Jupyter Lab >= version 4.0. Should the code in https://github.com/quarto-dev/quarto-cli/blob/7ca42c0ed2cd1beedba6c246fffa017d03289cd5/src/command/use/commands/binder/binder.ts be simplified?

[cderv]

Possibly it is an oversight, and we forgot to update this configuration while we update the jupyterlab extension.

Is this working of with 0.3.5 latest https://pypi.org/project/jupyterlab-quarto/ ?

[cderv]

So I have looked at the complete code and this is

quarto-cli/src/command/use/commands/binder/binder.ts

Lines 391 to 405 in e8eefd9

	if (jupyterLab4) {
	if (projEnv.codeEnvironment === "vscode") {
	pythonConfig.pip?.push(
	"git+https://github.com/trungleduc/jupyter-server-proxy@lab4",
	);
	}
	pythonConfig.pip?.push("jupyterlab-quarto");
	} else {
	if (projEnv.codeEnvironment === "vscode") {
	pythonConfig.pip?.push("jupyter-server-proxy");
	}
	pythonConfig.pip?.push("jupyterlab-quarto==0.1.45");
	}

So for JupyterLab > 4, the latest jupyterlab-quarto will be used. No specifier.
For JupyterLab before that, version is pinned to 0.1.45 because this is the latest working one
v0.1.45 is the latest version to support JupyterLab before 4 (quarto-dev/jupyterlab-quarto@1bafec9)

[rgaiacs]

Thanks for the reply @cderv.

mybinder.org will use Jupyter Lab Version 4.3.5 for a project that does not include a configuration file (requirements, environment.yml, pipfile). Because of the logic in

quarto-cli/src/command/use/commands/binder/binder.ts

Lines 270 to 288 in e8eefd9

	const envs = env.environments;
	// Look in requirements, environment.yml, pipfile for hints
	// that JL4 will be used (hacky to use regex but using for hint)
	const envMatchers: Record<string, RegExp> = {};
	envMatchers["requirements.txt"] = /jupyterlab>*=*4.*./g;
	envMatchers["environment.yml"] = /jupyterlab *>*=*4.*./g;
	envMatchers["pipfile"] = /jupyterlab = "*>*=*4.*."/g;
	const hasJL4 = envs.some((env) => {
	const matcher = envMatchers[env];
	if (!matcher) {
	return false;
	}
	const contents = Deno.readTextFileSync(join(context.dir, env));
	return contents.match(matcher);
	});
	return hasJL4;

a project without a configuration file will install the pinned jupyterlab-quarto 0.1.45. Maybe the logic need to change to check if the mybinder.org user pinned the Jupyter Lab installation to version 3.

[cderv]

mybinder.org will use Jupyter Lab Version 4.3.5 for a project that does not include a configuration file (requirements, environment.yml, pipfile).

Oh so this is indeed a bug related to mybinder new default then. I missed that.

This seems it should indeed by adapted. Do you want to PR something ? Otherwise, I'll move to an issue and we'll handle it.

Thanks again

[rgaiacs]

I will submit a PR in the next week. Thanks!