links parameters with quarto.doc.add_html_dependency #4304

jdlom · 2023-02-09T20:42:16Z

jdlom
Feb 9, 2023

I try to add links in <head> with quarto.doc.add_html_dependency.

This works like a charm with css and js libraries but it does not work with favicon.

My dependencies tree :

├───dsfr-1.5.1
│   └───dist
│       ├───dsfr
│       ├───favicon
│       ├───fonts
│       └───icons
└───partials

What am I missing ?

There is no example with links in the documentation.

For now I'm doing like this :

local format = string.format
version="1.5.1"
dist_path = format("dsfr-%s/dist/", version)
dsfr_path = format("%sdsfr/", dist_path)
--dsfr_favicon = format("%s/favicon/", dist_path)

local function ensureHtmlDeps()
  
  quarto.doc.add_html_dependency({
    name = "dsfr",
    version = version,
    scripts = {
      { path = dsfr_path .. "dsfr.module.min.js",
        attribs = { type = "module"}, afterBody
      },
      { path = dsfr_path .. "dsfr.nomodule.min.js",
        attribs = { nomodule = ""}
      }

    },
    stylesheets = { dsfr_path .."dsfr.min.css"},
    -- this part above does not work
    links = {
      {
        rel = "apple-touch-icon",
        href = dist_path .. "favicon/apple-touch-icon.png"
      },
      {
        rel = "icon",
        href = dist_path .."favicon/favicon.svg",
        type ="image/svg+xml"
      },
      {
        rel = "shortcut icon",
        href = dist_path .."favicon/favicon.ico",
        type = "image/x-icon"
      } ,
      {
        rel = "manifest",
        href = dist_path .. "favicon/manifest.webmanifest",
        crossorigin="use-credentials"
      }
      
    }
    
  })
end

ver
Microsoft Windows [version 10.0.19044.2486]
quarto --version
1.2.335
quarto pandoc --version
pandoc 2.19.2

jdlom · 2023-02-09T23:00:35Z

jdlom
Feb 9, 2023
Author

quarto-cli/src/resources/pandoc/datadir/init.lua

Lines 1535 to 1543 in 6f4599c

    
           local function resolveDependencyLinkTags(linkTags) 
        
              if linkTags ~= nil then 
        
                 for i, v in ipairs(linkTags) do 
        
                    v.href = resolvePath(v.href) 
        
                 end 
        
              else 
        
                 return nil 
        
              end 
        
           end

I think the linkTags should be returned.
I have tested and the links appear in my head section even if the href are not yet good...

Should I report a bug ?

2 replies

cscheid Feb 10, 2023
Maintainer

Oh yeah that totally looks like a bug to me as well. Thanks for finding it! I'll fix that right away.

cscheid Feb 10, 2023
Maintainer

We have a PR open now: #4305, this should be fixed on main soon. Thank you again!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

links parameters with quarto.doc.add_html_dependency #4304

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 1 comment 2 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

links parameters with quarto.doc.add_html_dependency #4304

Uh oh!

Uh oh!

jdlom Feb 9, 2023

Replies: 1 comment · 2 replies

Uh oh!

Uh oh!

jdlom Feb 9, 2023 Author

Uh oh!

cscheid Feb 10, 2023 Maintainer

Uh oh!

cscheid Feb 10, 2023 Maintainer

jdlom
Feb 9, 2023

Replies: 1 comment 2 replies

jdlom
Feb 9, 2023
Author

cscheid Feb 10, 2023
Maintainer

cscheid Feb 10, 2023
Maintainer