link-citation suppress-bibliography doesn't compile since pandoc 3.1.7

[danieltomasz]

Description

I am using quarto 1.4.451, I am wrtiing my my thesis via quarto and latex, recently something changed so I cannot compile my document with

suppress-bibliography: true
citeproc: true

I need to to set suppress-bibliography: false, additionally when I downgrade to 1.3.x I can compile the same document.
The document was fine 1 month ago.
I can paste Minimal reproducible example, but maybe there is a quick reply?

[cscheid]

I can paste Minimal reproducible example

Please do that, thank you.

[danieltomasz]

I isolated the lines causing troubles

1. create the default project in vscode

replace format with thos code chunk

format:
  pdf:
    link-citations: true
    pdf-engine: xelatex

suppress-bibliography: true
citeproc: true

so _quarto.yml looks like this

project:
  type: book

book:
  title: "test"
  author: "Norah Jones"
  date: "10/31/2023"
  chapters:
    - index.qmd
    - intro.qmd
    - summary.qmd
    - references.qmd

bibliography: references.bib

format:
  pdf:
    link-citations: true

suppress-bibliography: true
citeproc: true

the the default example (with knuth citation) will not compile via quarto preview

Rendering PDF
running xelatex - 1
  This is XeTeX, Version 3.141592653-2.6-0.999995 (TeX Live 2023) (preloaded format=xelatex)
   restricted \write18 enabled.
  entering extended mode
  
updating tlmgr

updating existing packages
ERROR: 
compilation failed- error
Undefined control sequence.
l.172 See Knuth (\citeproc
                          {ref-knuth84}{1984}) for additional discussion of 

[danieltomasz]

link-citations: true seems to causing it (it makes sense), on the other hand I would expect it should be some kind of conditional check if suppress bibliography is not true (to reproduce effect from earlier releases)

I am on 1.4.460

[cderv]

I believe this is an issue with Pandoc itself.

Take this example

---
title: test
references:
- type: article-journal
  id: WatsonCrick1953
  author:
  - family: Watson
    given: J. D.
  - family: Crick
    given: F. H. C.
  issued:
    date-parts:
    - - 1953
      - 4
      - 25
  title: 'Molecular structure of nucleic acids: a structure for
    deoxyribose nucleic acid'
  title-short: Molecular structure of nucleic acids
  container-title: Nature
  volume: 171
  issue: 4356
  page: 737-738
  DOI: 10.1038/171737a0
  URL: https://www.nature.com/articles/171737a0
  language: en-GB
link-citations: true
suppress-bibliography: true
--- 

See @WatsonCrick1953 for additional discussion

Now render with

quarto pandoc -f markdown -t latex -s --citeproc -o test.pdf test.qmd

You will get the error; You could also do -o test.tex and look inside the file - there is no defintion of the \citeproc command.

Remove suppress-bibliography: true and run

quarto pandoc -f markdown -t latex -s --citeproc -o test.tex test.qmd

The citation information from pandoc are correctly inserted

% definitions for citeproc citations
\NewDocumentCommand\citeproctext{}{}
\NewDocumentCommand\citeproc{mm}{%
  \begingroup\def\citeproctext{#2}\cite{#1}\endgroup}

It comes from template https://github.com/jgm/pandoc/blob/d3d0406515cb6aae6f43e60dfa37014bdd91e79c/data/templates/default.latex#L337-L341

so somehow something deactivate the insertion. or did not change the use of

(\citeproc{ref-WatsonCrick1953}{1953})

Running with Quarto 1.3 which has a different pandoc we see that the .tex is changed

 (\protect\hyperlink{ref-WatsonCrick1953}{1953})

This means this is an issue between this two version of pandoc

Doing a bit of bisecting with pandoc version, first one to fail is 3.1.7 (https://github.com/jgm/pandoc/releases/tag/3.1.7) - which you mentioned in your title 🤦

They did some changes about LaTeX writer and citation linking. So possibly related.

I'll open an issue upstream.

[cderv]

Though I am thinking we can deactivate link-citations maybe if suppress-bibliography: true as this is not working (and not useful and it links nowhere.... 🤔 )

[cderv]

Issue opened at jgm/pandoc#9163

[cderv]

Update:

This has now been fix in dev pandoc: jgm/pandoc@db92f61

It will be available in next Pandoc, so soon in quarto...

[danieltomasz]

@cderv thanks for taking care of it !
One question - I see Quarto daily release notes are pointing to Pandoc 3.1.6.1, the release notes aren't updated so often? (The quarto pandoc --version showing `3.1.8')
https://quarto.org/docs/download/

[cderv]

Thanks we forgot to update it seems. 3.1.8 is the right one.

[cderv]

Fixed in 1968925