brand yaml: relative logo paths #11069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonwoodhull
force-pushed
the
feature/brand-yaml-relative-logo-paths
branch
4 times, most recently
from
1c22e37 to
24144b5
Compare
|
As discussed, we can clean up the implementation of logo paths later, and replacing Will merge once tests pass. |
i think there is a better place to do this, since fonts do this elsewhere
questionable, maybe we should be using a different metadata key here
gordonwoodhull
force-pushed
the
feature/brand-yaml-relative-logo-paths
branch
from
24144b5 to
0a02faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple questions for @cscheid here, so leaving this as draft:
This implements the relative path to the brand yaml logo resources in
core/brand/brand.ts. I think the implementation is good but I wonder if this belongs somewhere else? since I don't find the similar implementation fortypographyin this source file (buttypographybrand.yml-relative paths do work, as tested in this PR).I've been populating the
brandkey in the metadata with an object containing some of the processed brand yaml data, e.g.brand.typography.headings.familyetc., for the template to consume.However, this may conflict when the metadata contains an explicit
brand: path/brand.ymlentry.Here I replace the string (
Inlines) with an object, which feels problematic. Should we renamebranddata to something else? You expressed the opinion that this data should be available to custom lua filters.