Skip to content

Conversation

@gadenbuie
Copy link
Collaborator

Small fix to resolve colors in brand.typography.*.{color,background-color} before sending them to Sass.

Prior to this change the following yaml

color:
  palette:
    bright_pink: "#FF3D7F"
    orange: "#FF6F20"
    gray_light: "#E0E0E0"
  primary: orange
  danger: bright_pink

typography:
  headings:
    color: primary
  monospace-inline:
    color: bright_pink
  monospace-block:
    background-color: gray_light

would set

$headings-color: primary !default;
$code-color: bright_pink !default;
$pre-color: bright_pink !default;
$pre-bg: gray_light !default;

This PR calls brand.getColor() on the value of color or background-color properties before passing to Sass.

@gadenbuie gadenbuie requested a review from cscheid October 18, 2024 15:04
@cscheid
Copy link
Collaborator

cscheid commented Oct 18, 2024

This fix exactly was on my plate for today. I'd have implemented it exactly like that. Thank you!

@cscheid cscheid merged commit f3b2f70 into main Oct 18, 2024
47 checks passed
@cscheid cscheid deleted the brand/fix-typography-colors branch October 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants