Compatibility with the latest patches to xmlp. #11781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. SAXParser.parse now expects a ReadableStream. 2. SAXParser.parse now works on the input stream directly and closes it at the end
Collaborator
|
Thanks for the PR, but we can't yet support Deno 2 for a number of reasons, so we can't take this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In clipcrow/xmlp#3 and clipcrow/xmlp@d215ffa, xmlp was changed to support Deno 2. This PR adapts the usage in website-sitemap.ts to those changes.
xmlp hasn't released a new version with these changes despite my ask for it in clipcrow/xmlp#5. Would love to get some thoughts on how to handle this case.
Checklist
I have (if applicable):