Bugfix/11860 #11862
Merged
Bugfix/11860 #11862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 🚀 I had no doubt ! I was quite sure we wouldn't need the automation on CI for static solution - It is hard to share clearly some thoughts by written github comments sometimes 😅 - Sorry is was unclear. 😉 Thanks for quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11860. This implements the "dynamic" solution for the bug, where we now bundle linked ES6 modules with
esbuildand replace them with data URLs. This is a more comprehensive solution than Pandoc's, which stops at the first include, breaking ES6 scripts that have import statements in them.cc @cderv :D