brand logo shortcode takes brandMode #12566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonwoodhull
added a commit
that referenced
this pull request
Apr 16, 2025
minor cleanup for #12566
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12564 and allows choosing the dark brand.
Note that we still don't really resolve dark logos; this only chooses properly chooses the light brand or dark brand, but still pulls the light logo from there.
In 1.8 I argue we should repurpose this parameter to actually find a dark logo if requested, when there is a more sensible search provided in #12341 dark logo.
This PR includes an unrelated code cleanup in
brand.ts, pulling out an unintentionally nested loop for clarity.