Skip to content

create - force --no-open when inside Posit Workbench #12967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025
Merged

create - force --no-open when inside Posit Workbench #12967

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24e9355
create - force `--no-open` when inside Posit Workbench
cderv Jun 20, 2025
18c12f5
rename isRStudioWorkbench to isPositWorkbench
cderv Jun 20, 2025
49f6f9e
Add to changelog
cderv Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/command/create/cmd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ import { extensionArtifactCreator } from "./artifacts/extension.ts";
import { projectArtifactCreator } from "./artifacts/project.ts";
import { kEditorInfos, scanForEditors } from "./editor.ts";

import { isInteractiveTerminal } from "../../core/platform.ts";
import {
isInteractiveTerminal,
isRStudioWorkbench,
} from "../../core/platform.ts";
import { runningInCI } from "../../core/ci-info.ts";

import { Command } from "cliffy/command/mod.ts";
Expand Down Expand Up @@ -56,6 +59,16 @@ export const createCommand = new Command()
const isInteractive = isInteractiveTerminal() && !runningInCI();
const allowPrompt = isInteractive && !!options.prompt && !options.json;

// Specific case where opening automatically in an editor is not allowed
if (options.open !== false && isRStudioWorkbench()) {
Copy link

@jthomasmock jthomasmock Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit and this might be an older boolean, but isPositWorkbench would be more appropriate.

Copy link
Collaborator Author

@cderv cderv Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is an older function

quarto-cli/src/core/platform.ts

Lines 37 to 41 in 24e9355

export function isRStudioWorkbench() {
// RS_SERVER_URL e.g. https://daily-rsw.soleng.rstudioservices.com/
// RS_SESSION_URL e.g. /s/eae053c9ab5a71168ee19/
return !!Deno.env.get("RS_SERVER_URL") && !!Deno.env.get("RS_SESSION_URL");
}

I did not bother renaming, but I can for sure.

Copy link
Collaborator Author

@cderv cderv Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 18c12f5

Probably best to also change in quarto-dev/quarto ?

https://github.com/quarto-dev/quarto/blob/57ed6fb2ab6066a6a4f0333c0c968586701e006a/apps/vscode/src/core/platform.ts#L22-L26

if (options.open !== undefined) {
info(
`The --open option is not supported in Posit Workbench - ignoring`,
);
}
options.open = false;
}

// Resolve the type into an artifact
const resolved = await resolveArtifact(
type,
Expand Down
Loading