tests - ignore failed test due to inaccessible repo #13298
Conversation
- Add `_` to .qmd file so that they are not picked up by test suite as test files. We don't delete them because we plan to recreate the missing repo and update the test - Add a README in the folder to explain the situation - Remove the test from list of tests in `timing-for-ci.txt` so that they are not run in CI as part of parallel testing.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
cderv
force-pushed
the
tests/fix-giscus-example-tests
branch
from
fefdc12 to
d76810f
Compare
|
Those test will need to be reactivated in some manner. They are related to giscus. I know we added more, since but still. Anyhow, this PR is meant to unblock the failure due to the example repo being 404 now. I don't have a copy of its content, so I can't just change the url. |
|
Which repository specifically disappeared? |
|
Sorry I should have mentioned. This one |
|
These seem to be just smoke tests, so the content doesn't matter. The pages preview fine when I substitute I'm not sure how the 404 in the giscus iframe is detected. It's not a render failure. I think I saw the error once, but I'm not finding it in the logs. #13319 passes CI |
_to .qmd file so that they are not picked up by test suite as test files. We don't delete them because we plan to recreate the missing repo and update the testtiming-for-ci.txtso that they are not run in CI as part of parallel testing.Our test suites was failing because one repo used in test has been removed from Github.
It was using some giscus-examples and I don't have a copy of it.
So we'll need to look into those tests, recreate or remove.
For now I believe the following will help ignore the test