processx can return different error than the one from error_on_status

Author: cderv

R/quarto.R

@@ -140,27 +140,35 @@ quarto_run <- function(
       )
     },
     error = function(e) {
-      msg <- c(x = "Error running quarto cli.")
-      # if there is an error message from quarto CLI, add it to the message
-      if (e$stderr != "") {
-        quarto_error_msg <- xfun::split_lines(e$stderr)
-        names(quarto_error_msg) <- rep(" ", length(quarto_error_msg))
-        msg <- c(
-          msg,
-          " " = paste0(rep("-", nchar(msg)), collapse = ""),
-          quarto_error_msg
+      if (!inherits(e, "system_command_status_error")) {
+        cli::cli_abort(
+          c("!" = "Error running quarto CLI from R."),
+          call = .call,
+          parent = e
         )
-      }
+      } else {
+        msg <- c(x = "Error returned by quarto CLI.")
+        # if there is an error message from quarto CLI, add it to the message
+        if (e$stderr != "") {
+          quarto_error_msg <- xfun::split_lines(e$stderr)
+          names(quarto_error_msg) <- rep(" ", length(quarto_error_msg))
+          msg <- c(
+            msg,
+            " " = paste0(rep("-", nchar(msg)), collapse = ""),
+            quarto_error_msg
+          )
+        }
 
-      # if `--quiet` has been set, quarto CLI won't report any error (e$stderr will be empty)
-      # So remind user to run without `--quiet` to see the full error message
-      if (cli_arg_quiet() %in% args)
-        msg <- c(
-          msg,
-          "i" = "Rerun with `quiet = FALSE` to see the full error message."
-        )
+        # if `--quiet` has been set, quarto CLI won't report any error (e$stderr will be empty)
+        # So remind user to run without `--quiet` to see the full error message
+        if (cli_arg_quiet() %in% args)
+          msg <- c(
+            msg,
+            "i" = "Rerun with `quiet = FALSE` to see the full error message."
+          )
 
-      cli::cli_abort(msg, call = .call, parent = e)
+        cli::cli_abort(msg, call = .call, parent = e)
+      }
     }
   )
   invisible(res)

tests/testthat/_snaps/quarto.md

@@ -4,7 +4,7 @@
       quarto_run(c("rend", "--quiet"))
     Condition
       Error:
-      x Error running quarto cli.
+      x Error returned by quarto CLI.
       i Rerun with `quiet = FALSE` to see the full error message.
       Caused by error:
       ! System command 'quarto' failed
@@ -15,8 +15,8 @@
       quarto_inspect()
     Condition
       Error in `quarto_inspect()`:
-      x Error running quarto cli.
-        -------------------------
+      x Error returned by quarto CLI.
+        -----------------------------
         ERROR: Book chapter 'intro.qmd' not found
         
         Stack trace: