Polish quarto_create_project() (#206)

* Work on docs

* "Enter" should be like "Y"

* Suppress the warning about no project title

* Start running these tests

* Add to NEWS and bump version

---------

Co-authored-by: Christophe Dervieux <[email protected]>

Author: jennybc

NEWS.md

@@ -1,5 +1,7 @@
 # quarto (development version)
 
+- `quarto_create_project()` offers better user experience now (thanks, @jennybc, #206, #153).
+
 - `quarto_preview()` gains a `quiet` argument to suppress any output from R or Quarto CLI (thanks, @cwickham, #232.)
 
 - Add some helpers function `theme_brand_*` and `theme_colors_*` to help theme with dark and light brand using some common graph and table packages (thanks,  @gordonwoodhull, [#234](https://github.com/quarto-dev/quarto-r/issues/234)).

R/create.R

@@ -1,23 +1,31 @@
 #' Create a quarto project
 #'
-#' This function calls `quarto create project <type> <name>`. It will create a
-#' new directory with the project name and add some skeletons files for the
-#' project type chosen.
+#' This function calls `quarto create project <type> <name>`. It creates a new
+#' directory with the project name, inside the requested parent directory, and
+#' adds some starter files that are appropriate to the project type.
 #'
 #' # Quarto version required
 #'
-#' This function require Quarto 1.4 or higher. Use [`quarto_version()`]to check
-#' the version of Quarto detected.
+#' This function requires Quarto 1.4 or higher. Use [quarto_version()] to see
+#' your current Quarto version.
 #'
-#' @param type The type of project to create. As of 1.4, it can be one of
+#' @param type The type of project to create. As of Quarto 1.4, it can be one of
 #'   `r paste0("\\code{", paste(quarto_project_type, collapse = "}, \\code{"),"}")`.
 #' @param name The name of the project and the directory that will be created.
-#' @param dir  The directory where to create the new Quarto project.
+#' @param dir The directory in which to create the new Quarto project, i.e. the
+#'   parent directory.
 #'
 #' @seealso Quarto documentation on [Quarto projects](https://quarto.org/docs/projects/quarto-projects.html)
 #'
 #' @inheritParams quarto_render
-#' @inheritParams quarto_add_extension
+#' @param no_prompt Do not prompt to approve the creation of the new project
+#'   folder.
+#'
+#' @examples
+#' \dontrun{
+#' quarto_create_project("my-first-quarto-project", dir = "~/tmp")
+#' }
+#'
 #'
 #' @export
 quarto_create_project <- function(
@@ -43,7 +51,7 @@ quarto_create_project <- function(
       "This will create a new Quarto {.emph {type}} project as a folder named {.strong {name}} in {.path {xfun::normalize_path(dir)}}."
     ))
     prompt_value <- tolower(readline(sprintf("Do you want to proceed (Y/n)? ")))
-    if (!prompt_value %in% "y") {
+    if (!prompt_value %in% c("", "y")) {
       cli::cli_abort("Operation aborted.")
     }
   }
@@ -54,6 +62,7 @@ quarto_create_project <- function(
     "project",
     type,
     name,
+    name,
     "--no-prompt",
     "--no-open",
     if (is_quiet(quiet)) cli_arg_quiet(),

man/quarto_create_project.Rd

@@ -1,9 +1,5 @@
 test_that("Create a quarto project", {
   skip_if_no_quarto("1.4")
-  # TODO: Fix the test once issue solve upstream
-  # - https://github.com/quarto-dev/quarto-cli/issues/8809
-  # - https://github.com/quarto-dev/quarto-r/issues/153
-  skip_if_quarto("1.5")
   expect_snapshot(
     error = TRUE,
     quarto_create_project()
@@ -16,10 +12,6 @@ test_that("Create a quarto project", {
 
 test_that("Create a quarto project in another directory", {
   skip_if_no_quarto("1.4")
-  # TODO: Fix the test once issue solve upstream
-  # - https://github.com/quarto-dev/quarto-cli/issues/8809
-  # - https://github.com/quarto-dev/quarto-r/issues/153
-  skip_if_quarto("1.5")
   tempdir <- withr::local_tempdir()
   curr_wd <- getwd()
   expect_no_error(quarto_create_project(