-
Notifications
You must be signed in to change notification settings - Fork 990
Update shortcodes-and-filters.yml #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds kroki extension. Uses the Kroki API via HTTP GET requests. Supports custom Kroki URLs and output formats like SVG and PNG.
|
Thanks. What is the difference with the other kroki extension list just above ? quarto-web/docs/extensions/listings/shortcodes-and-filters.yml Lines 337 to 342 in c968006
Your README does not mention anything either about this other one. The repo are named the same though the extension name seems to be different. Yours is older, right? Would this make sense to have both extension be only one? We don't have hard rules yet in listing duplicated extensions, but this will be for sure a question that could come. So I am curious. 😄 |
|
Yes! My extension is older 😄, I originally built it for my undergraduate research project at university and ended up forgetting to request its addition to the public list of extensions. Even though the repository has the same name, the filter names are different, so I don't think there will be any "compatibility" issues If someone installs both extensions, they will be in their respective paths:
The differences between my extension and the one that already exists are:
Thanks for the question! Let me know if you need anything else, I’m here to help. |
|
Great, thanks for the details about the differences. It seems yours has a bit more features. Out of curiosity, did you try to contact the maintainer of the other one to see if you could maybe co-maintain one? Or were you contacted? Sometimes projects can't be 'merged' because views are different, but with tools related to services, like Kroki seems to be, it is often a matter of time for feature coverage by the maintainers. Anyhow, just suggesting - I'll be happy to be the one making the introduction as a Quarto team member. We would all benefit from a clean ecosystem! |
|
/deploy-preview |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1695.quarto.org |
Answering your questions: I wasn't contacted by the maintainer of the other repository, and I also haven't tried to reach out. I only found out about it today while preparing this pull request. That said, I’d love to move forward with the idea of creating an official Kroki extension for Quarto, with the support and approval of the Quarto team. I'd also be happy to invite the maintainers of the other extension to collaborate if they’re open to it. If you’re willing to make the introduction, that would be great! I’d really appreciate your help in bringing us together. I'm fully committed to maintaining the extension, keeping it up to date, and addressing any bugs that may arise 😃 . |
|
Successfully created backport PR for |
Done in the other extension repo: |
Adds kroki extension. Uses the Kroki API via HTTP GET requests. Supports custom Kroki URLs and output formats like SVG and PNG.