Skip to content

Conversation

@GabrielCoffee9
Copy link
Contributor

Adds kroki extension. Uses the Kroki API via HTTP GET requests. Supports custom Kroki URLs and output formats like SVG and PNG.

Adds kroki extension. Uses the Kroki API via HTTP GET requests. Supports custom Kroki URLs and output formats like SVG and PNG.
@cderv
Copy link
Collaborator

cderv commented Jun 16, 2025

Thanks.

What is the difference with the other kroki extension list just above ?

- name: kroki
path: https://github.com/fermarsan/quarto-kroki
author: '[fermarsan](https://github.com/fermarsan)'
description: >
Render Kroki diagrams in Quarto documents (HTML and PDF)
This uses the Kroki HTTP API via curl, doing a POST request.

Your README does not mention anything either about this other one. The repo are named the same

though the extension name seems to be different.

Yours is older, right?

Would this make sense to have both extension be only one?
Or can we explain the difference between the two?

We don't have hard rules yet in listing duplicated extensions, but this will be for sure a question that could come. So I am curious. 😄

@GabrielCoffee9
Copy link
Contributor Author

Yes! My extension is older 😄, I originally built it for my undergraduate research project at university and ended up forgetting to request its addition to the public list of extensions.

Even though the repository has the same name, the filter names are different, so I don't think there will be any "compatibility" issues

If someone installs both extensions, they will be in their respective paths:

  • _extensions/fermarsan/quarto-kroki
  • _extensions/resepemb/kroki

The differences between my extension and the one that already exists are:

  • Mine uses the GET request method instead of POST.
  • It allows customizing the Kroki service URL, which makes it possible to use self-hosted solutions, for example.
  • It's also possible to specify the image format of the diagram that will be returned.

Thanks for the question! Let me know if you need anything else, I’m here to help.

@cderv
Copy link
Collaborator

cderv commented Jun 16, 2025

Great, thanks for the details about the differences. It seems yours has a bit more features.
I know see your description stats that quite obviously.

Out of curiosity, did you try to contact the maintainer of the other one to see if you could maybe co-maintain one? Or were you contacted?

Sometimes projects can't be 'merged' because views are different, but with tools related to services, like Kroki seems to be, it is often a matter of time for feature coverage by the maintainers.

Anyhow, just suggesting - I'll be happy to be the one making the introduction as a Quarto team member. We would all benefit from a clean ecosystem!

@cderv
Copy link
Collaborator

cderv commented Jun 16, 2025

/deploy-preview

@github-actions
Copy link
Contributor

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1695.quarto.org

@GabrielCoffee9
Copy link
Contributor Author

Great, thanks for the details about the differences. It seems yours has a bit more features. I know see your description stats that quite obviously.

Out of curiosity, did you try to contact the maintainer of the other one to see if you could maybe co-maintain one? Or were you contacted?

Sometimes projects can't be 'merged' because views are different, but with tools related to services, like Kroki seems to be, it is often a matter of time for feature coverage by the maintainers.

Anyhow, just suggesting - I'll be happy to be the one making the introduction as a Quarto team member. We would all benefit from a clean ecosystem!

Answering your questions: I wasn't contacted by the maintainer of the other repository, and I also haven't tried to reach out. I only found out about it today while preparing this pull request.

That said, I’d love to move forward with the idea of creating an official Kroki extension for Quarto, with the support and approval of the Quarto team. I'd also be happy to invite the maintainers of the other extension to collaborate if they’re open to it.

If you’re willing to make the introduction, that would be great! I’d really appreciate your help in bringing us together.

I'm fully committed to maintaining the extension, keeping it up to date, and addressing any bugs that may arise 😃 .

@cderv cderv merged commit b0a5e40 into quarto-dev:main Jun 17, 2025
3 checks passed
@github-actions
Copy link
Contributor

Successfully created backport PR for prerelease:

@cderv
Copy link
Collaborator

cderv commented Jun 17, 2025

If you’re willing to make the introduction, that would be great! I’d really appreciate your help in bringing us together.

Done in the other extension repo:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants