Skip to content

Commit 11d3479

Browse files
committed
Remove redundant config watching
1 parent b260250 commit 11d3479

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

apps/lsp/src/config.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,9 @@ export class ConfigurationManager extends Disposable {
172172
}
173173

174174
public async subscribe() {
175-
// Ignore the settings in parameters, the modern usage is to fetch the settings
176-
// when we get this notification
175+
// Ignore the settings in parameters, the modern usage is to fetch the
176+
// settings when we get this notification. This causes the client to send
177+
// any updates for settings under the `quarto` section.
177178
this.connection_.onDidChangeConfiguration((_params) => {
178179
this._logger.logNotification('didChangeConfiguration');
179180
this.update();

apps/vscode/src/lsp/client.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -147,17 +147,6 @@ export async function activateLsp(
147147
clientOptions
148148
);
149149

150-
// Notify LSP of quarto setting changes
151-
context.subscriptions.push(workspace.onDidChangeConfiguration(e => {
152-
if (client.state !== State.Running) {
153-
return;
154-
}
155-
156-
if (e.affectsConfiguration("quarto")) {
157-
client.sendNotification("workspace/didChangeConfiguration", {});
158-
}
159-
}));
160-
161150
// return once the server is running
162151
return new Promise<LanguageClient>((resolve, reject) => {
163152

0 commit comments

Comments
 (0)