Skip to content

Commit 1375251

Browse files
authored
Add allowIncomplete to runtime.executeCode() (#664)
* Add `allowIncomplete` to `runtime.executeCode()` * Update changelog
1 parent 46c6d38 commit 1375251

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

apps/vscode/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 1.119.0 (unreleased)
44

55
- Use `QUARTO_VISUAL_EDITOR_CONFIRMED` > `PW_TEST` > `CI` to bypass (`true`) or force (`false`) the Visual Editor confirmation dialogue (<https://github.com/quarto-dev/quarto/pull/654>).
6+
- Fix behavior in Positron when running a cell containing invalid/incomplete code (<https://github.com/quarto-dev/quarto/pull/664>).
67

78
## 1.118.0 (Release on 2024-11-26)
89

apps/vscode/src/@types/hooks.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ declare module 'positron' {
1616
executeCode(
1717
languageId: string,
1818
code: string,
19-
focus: boolean
19+
focus: boolean,
20+
allowIncomplete: boolean
2021
): Thenable<boolean>;
2122
}
2223

apps/vscode/src/host/hooks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export function hooksExtensionHost(): ExtensionHost {
7474
// Our callback executes each block sequentially
7575
const callback = async () => {
7676
for (const block of blocks) {
77-
await runtime.executeCode(language, block, false);
77+
await runtime.executeCode(language, block, false, true);
7878
}
7979
}
8080

0 commit comments

Comments
 (0)