Pass logLevel via init options

Author: lionel-

apps/lsp/src/config.ts

@@ -140,6 +140,20 @@ export class ConfigurationManager extends Disposable {
     this._settings = defaultSettings();
   }
 
+  public init(logLevel?: string) {
+    const initLogLevel = LogFunctionLogger.parseLogLevel(
+      logLevel ?? "warn"
+    );
+
+    this._settings = {
+      ...this._settings,
+      quarto: {
+        ...this._settings.quarto,
+        logLevel: initLogLevel,
+      }
+    };
+  }
+
   public async update() {
     this._logger.logTrace('Sending \'configuration\' request');
     const settings = await this.connection_.workspace.getConfiguration();

apps/lsp/src/index.ts

@@ -73,6 +73,10 @@ let initializationOptions: LspInitializationOptions | undefined;
 let mdLs: IMdLanguageService | undefined;
 
 connection.onInitialize((params: InitializeParams) => {
+  // Set log level from initialization options if provided so that we use the
+  // expected level as soon as possible
+  configManager.init(params.initializationOptions?.logLevel);
+
   // We're connected, log messages via LSP
   logger.setConnection(connection);
   logger.logRequest('initialize');

apps/lsp/src/logging.ts

@@ -55,9 +55,6 @@ export class LogFunctionLogger extends Disposable implements ILogger {
     private readonly _logFn: typeof console.log,
   ) {
     super();
-
-    // Be verbose during init until we have a chance to get the user configuration
-    this._logLevel = LogLevel.Debug;
   }
 
   setConnection(connection: Connection) {

apps/vscode/src/lsp/client.ts

@@ -117,7 +117,8 @@ export async function activateLsp(
 
   // create client options
   const initializationOptions: LspInitializationOptions = {
-    quartoBinPath: quartoContext.binPath
+    quartoBinPath: quartoContext.binPath,
+    logLevel: config.get("server.logLevel"),
   };
 
   const documentSelectorPattern = semver.gte(quartoContext.version, "1.6.24") ?

packages/quarto-core/src/lsp.ts

@@ -15,4 +15,5 @@
 
 export interface LspInitializationOptions {
   quartoBinPath?: string;
-}
+  logLevel?: 'trace' | 'debug' | 'info' | 'warn' | 'error';
+}