Permadelete .vdoc temp files, bypassing the trash (#714)

* Permadelete `.vdoc` temp files, bypassing the trash

* CHANGELOG bullet

Author: DavisVaughan

apps/vscode/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## 1.122.0 (unreleased)
 
+- Language server temporary files are now permanently deleted, bypassing the trash can (<https://github.com/quarto-dev/quarto/pull/714>).
 - Change controls on Positron editor action bar and fix "Render on Save" behavior (<https://github.com/quarto-dev/quarto/pull/706>).
 - Turn off completions in visual mode in Positron, as a temporary stopgap until we can invest more in LSP features in the visual editor (<https://github.com/quarto-dev/quarto/pull/710>).
 

apps/vscode/src/vdoc/vdoc-tempfile.ts

@@ -75,12 +75,21 @@ export async function virtualDocUriFromTempFile(
   };
 }
 
-// delete a document
+/**
+ * Delete a virtual document's on disk temporary file
+ *
+ * Since this is an ephemeral file, we bypass the trash (Trash on Mac, Recycle
+ * Bin on Windows) and permadelete it instead so our trash isn't cluttered with
+ * thousands of these files. This should also avoid issues with users on network
+ * drives, which don't necessarily have access to their Recycle Bin (#708).
+ *
+ * @param doc The `TextDocument` to delete
+ */
 async function deleteDocument(doc: TextDocument) {
   try {
-    const edit = new WorkspaceEdit();
-    edit.deleteFile(doc.uri);
-    await workspace.applyEdit(edit);
+    await workspace.fs.delete(doc.uri, {
+      useTrash: false
+    });
   } catch (error) {
     const msg = error instanceof Error ? error.message : JSON.stringify(error);
     console.log(`Error removing vdoc at ${doc.fileName}: ${msg}`);